2019-10-11 15:08:40

by Thomas Bogendoerfer

Subject: [PATCH 1/3] rts: ds1685: remove not needed fields from private struct

A few of the fields in struct ds1685_priv aren't needed at all,
so we can remove it.

Signed-off-by: Thomas Bogendoerfer <[email protected]>
---
drivers/rtc/rtc-ds1685.c | 3 ---
include/linux/rtc/ds1685.h | 3 ---
2 files changed, 6 deletions(-)

diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
index 184e4a3e2bef..51f568473de8 100644
--- a/drivers/rtc/rtc-ds1685.c
+++ b/drivers/rtc/rtc-ds1685.c
@@ -1086,12 +1086,10 @@ ds1685_rtc_probe(struct platform_device *pdev)
* Set the base address for the rtc, and ioremap its
* registers.
*/
- rtc->baseaddr = res->start;
rtc->regs = devm_ioremap(&pdev->dev, res->start, rtc->size);
if (!rtc->regs)
return -ENOMEM;
}
- rtc->alloc_io_resources = pdata->alloc_io_resources;

/* Get the register step size. */
if (pdata->regstep > 0)
@@ -1271,7 +1269,6 @@ ds1685_rtc_probe(struct platform_device *pdev)
/* See if the platform doesn't support UIE. */
if (pdata->uie_unsupported)
rtc_dev->uie_unsupported = 1;
- rtc->uie_unsupported = pdata->uie_unsupported;

rtc->dev = rtc_dev;

diff --git a/include/linux/rtc/ds1685.h b/include/linux/rtc/ds1685.h
index 43aec568ba7c..b9671d00d964 100644
--- a/include/linux/rtc/ds1685.h
+++ b/include/linux/rtc/ds1685.h
@@ -43,13 +43,10 @@ struct ds1685_priv {
struct rtc_device *dev;
void __iomem *regs;
u32 regstep;
- resource_size_t baseaddr;
size_t size;
int irq_num;
bool bcd_mode;
bool no_irq;
- bool uie_unsupported;
- bool alloc_io_resources;
u8 (*read)(struct ds1685_priv *, int);
void (*write)(struct ds1685_priv *, int, u8);
void (*prepare_poweroff)(void);
--
2.16.4

2019-10-12 22:44:41

by Joshua Kinard

Subject: Re: [PATCH 1/3] rts: ds1685: remove not needed fields from private struct

On 10/11/2019 11:05, Thomas Bogendoerfer wrote:
> A few of the fields in struct ds1685_priv aren't needed at all,
> so we can remove it.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> drivers/rtc/rtc-ds1685.c | 3 ---
> include/linux/rtc/ds1685.h | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 184e4a3e2bef..51f568473de8 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1086,12 +1086,10 @@ ds1685_rtc_probe(struct platform_device *pdev)
> * Set the base address for the rtc, and ioremap its
> * registers.
> */
> - rtc->baseaddr = res->start;
> rtc->regs = devm_ioremap(&pdev->dev, res->start, rtc->size);
> if (!rtc->regs)
> return -ENOMEM;
> }
> - rtc->alloc_io_resources = pdata->alloc_io_resources;
>
> /* Get the register step size. */
> if (pdata->regstep > 0)
> @@ -1271,7 +1269,6 @@ ds1685_rtc_probe(struct platform_device *pdev)
> /* See if the platform doesn't support UIE. */
> if (pdata->uie_unsupported)
> rtc_dev->uie_unsupported = 1;
> - rtc->uie_unsupported = pdata->uie_unsupported;
>
> rtc->dev = rtc_dev;
>
> diff --git a/include/linux/rtc/ds1685.h b/include/linux/rtc/ds1685.h
> index 43aec568ba7c..b9671d00d964 100644
> --- a/include/linux/rtc/ds1685.h
> +++ b/include/linux/rtc/ds1685.h
> @@ -43,13 +43,10 @@ struct ds1685_priv {
> struct rtc_device *dev;
> void __iomem *regs;
> u32 regstep;
> - resource_size_t baseaddr;
> size_t size;
> int irq_num;
> bool bcd_mode;
> bool no_irq;
> - bool uie_unsupported;
> - bool alloc_io_resources;
> u8 (*read)(struct ds1685_priv *, int);
> void (*write)(struct ds1685_priv *, int, u8);
> void (*prepare_poweroff)(void);
>

Acked-by: Joshua Kinard <[email protected]>

2019-10-14 16:30:17

by Alexandre Belloni

Subject: Re: [PATCH 1/3] rts: ds1685: remove not needed fields from private struct

On 11/10/2019 17:05:43+0200, Thomas Bogendoerfer wrote:
> A few of the fields in struct ds1685_priv aren't needed at all,
> so we can remove it.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
> drivers/rtc/rtc-ds1685.c | 3 ---
> include/linux/rtc/ds1685.h | 3 ---
> 2 files changed, 6 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com