2019-12-03 06:59:48

by Can Guo

[permalink] [raw]
Subject: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
unique ID by appending the scsi host number to its device name.

Fixes: df032bf27 (scsi: ufs: Add a bsg endpoint that supports UPIUs)
Signed-off-by: Can Guo <[email protected]>
Reviewed-by: Avri Altman <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>

diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
index dc2f6d2..d2197a3 100644
--- a/drivers/scsi/ufs/ufs_bsg.c
+++ b/drivers/scsi/ufs/ufs_bsg.c
@@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
bsg_dev->parent = get_device(parent);
bsg_dev->release = ufs_bsg_node_release;

- dev_set_name(bsg_dev, "ufs-bsg");
+ dev_set_name(bsg_dev, "ufs-bsg%u", shost->host_no);

ret = device_add(bsg_dev);
if (ret)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2019-12-09 23:55:30

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg


Can,

You seem to be sending duplicates of almost every mail which makes it
hard for me (and patchwork) to track your series. The mails are
identical except for Message-Id:.

Also, don't resubmit patches just to add Reviewed-by: tags. Patchwork
will pick up the tags. Only resubmit if you are making changes. And if
you do, use -vN to bump the version.

> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
> unique ID by appending the scsi host number to its device name.
>
> Fixes: df032bf27 (scsi: ufs: Add a bsg endpoint that supports UPIUs)

Please use 12-char SHA and enclose commit summary in quotes. See:

Documentation/process/submitting-patches.rst

Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs")

> Signed-off-by: Can Guo <[email protected]>
> Reviewed-by: Avri Altman <[email protected]>
> Reviewed-by: Christoph Hellwig <[email protected]>

Applied to 5.5/scsi-fixes, thanks!

--
Martin K. Petersen Oracle Linux Engineering