2019-12-09 14:36:06

by Mukesh Ojha

Subject: [PATCH] irq_work: Fix comment for irq_work_run()

hotplug_cfd() does not exist anymore, update the
comment for irq_work_run() with smpcfd_dying_cpu().

Signed-off-by: Mukesh Ojha <[email protected]>
---
kernel/irq_work.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 828cc30..202a0d3 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -165,7 +165,7 @@ static void irq_work_run_list(struct llist_head *list)

/*
* hotplug calls this through:
- * hotplug_cfd() -> flush_smp_call_function_queue()
+ * smpcfd_dying_cpu() -> flush_smp_call_function_queue()
*/
void irq_work_run(void)
{
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2020-01-16 01:03:40

by Thomas Gleixner

Subject: Re: [PATCH] irq_work: Fix comment for irq_work_run()

Mukesh Ojha <[email protected]> writes:

> hotplug_cfd() does not exist anymore, update the
> comment for irq_work_run() with smpcfd_dying_cpu().

That's only half of the truth. Just check the output of:

git grep irq_work_run

So even if the s/hotplug_cfd/smpcfd_dying_cpu/ change is correct, this
comment is actively misleading.

Thanks,

tglx