2019-12-11 09:15:34

by Can Guo

Subject: [PATCH v2 3/3] arm64: defconfig: Compile ufs-bsg as a module

Compiling ufs-bsg as a module to improve flexibility of its usage.

Signed-off-by: Can Guo <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 8e05c39..169a6e6 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -227,6 +227,7 @@ CONFIG_SCSI_UFSHCD=y
CONFIG_SCSI_UFSHCD_PLATFORM=y
CONFIG_SCSI_UFS_QCOM=m
CONFIG_SCSI_UFS_HISI=y
+CONFIG_SCSI_UFS_BSG=m
CONFIG_ATA=y
CONFIG_SATA_AHCI=y
CONFIG_SATA_AHCI_PLATFORM=y
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2019-12-11 11:13:35

by Avri Altman

Subject: RE: [PATCH v2 3/3] arm64: defconfig: Compile ufs-bsg as a module

>
> Compiling ufs-bsg as a module to improve flexibility of its usage.
>
> Signed-off-by: Can Guo <[email protected]>
Not sure we want to make it loadable by default.
The platform vendor should decide if this module is available or not,
Don't you think?


> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index
> 8e05c39..169a6e6 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -227,6 +227,7 @@ CONFIG_SCSI_UFSHCD=y
> CONFIG_SCSI_UFSHCD_PLATFORM=y CONFIG_SCSI_UFS_QCOM=m
> CONFIG_SCSI_UFS_HISI=y
> +CONFIG_SCSI_UFS_BSG=m
> CONFIG_ATA=y
> CONFIG_SATA_AHCI=y
> CONFIG_SATA_AHCI_PLATFORM=y
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

2019-12-11 11:46:30

by Can Guo

Subject: Re: [PATCH v2 3/3] arm64: defconfig: Compile ufs-bsg as a module

On 2019-12-11 19:11, Avri Altman wrote:
>>
>> Compiling ufs-bsg as a module to improve flexibility of its usage.
>>
>> Signed-off-by: Can Guo <[email protected]>
> Not sure we want to make it loadable by default.
> The platform vendor should decide if this module is available or not,
> Don't you think?
>
>

Agree, I will remove this change from patchset in next versioin of it.

Thanks,

Can Guo.

>> ---
>> arch/arm64/configs/defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig
>> b/arch/arm64/configs/defconfig index
>> 8e05c39..169a6e6 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -227,6 +227,7 @@ CONFIG_SCSI_UFSHCD=y
>> CONFIG_SCSI_UFSHCD_PLATFORM=y CONFIG_SCSI_UFS_QCOM=m
>> CONFIG_SCSI_UFS_HISI=y
>> +CONFIG_SCSI_UFS_BSG=m
>> CONFIG_ATA=y
>> CONFIG_SATA_AHCI=y
>> CONFIG_SATA_AHCI_PLATFORM=y
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project