2020-09-10 16:26:08

by Pintu Kumar

[permalink] [raw]
Subject: [PATCH] mm/slab.h: Fix duplicate include file kmemleak.h

As I was browsing through this code, I found that linux/kmemleak.h
was declared twice.

When I run ./scripts/checkincludes.pl it reported the same:
mm/slab.h: linux/kmemleak.h is included more than once.

Thus removing the last included header.

Signed-off-by: Pintu Kumar <[email protected]>
---
mm/slab.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/slab.h b/mm/slab.h
index 6cc323f..95e5cc1 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -46,7 +46,6 @@ struct kmem_cache {
#include <linux/kmemleak.h>
#include <linux/random.h>
#include <linux/sched/mm.h>
-#include <linux/kmemleak.h>

/*
* State of the slab allocator.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


2020-09-10 17:54:37

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [PATCH] mm/slab.h: Fix duplicate include file kmemleak.h

On Thu, Sep 10, 2020 at 04:13:56PM +0000, Pintu Kumar wrote:
> As I was browsing through this code, I found that linux/kmemleak.h
> was declared twice.
>
> When I run ./scripts/checkincludes.pl it reported the same:
> mm/slab.h: linux/kmemleak.h is included more than once.

Already reported yesterday and also on August 18th.