Hi,
On Thu, Sep 10, 2020 at 5:55 AM satya priya <[email protected]> wrote:
>
> Add a suitable sleep configuration for uart3 to support Bluetooth wakeup.
>
> If QUP function is selected in sleep state, UART RTS/RFR is pulled high
> during suspend and BT SoC not able to send wakeup bytes. So, configure
> GPIO mode in sleep state to keep it low during suspend.
>
> Signed-off-by: satya priya <[email protected]>
> ---
> Changes in V5:
> - Newly added in V5. This patch adds wakeup support for trogdor board files.
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 48 ++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
Note: I can't find this email on any of the mailing lists. Can you
check your config? I tried:
http://lore.kernel.org/r/[email protected]
...and also checked patchwork servers. I only see patch 1 and 2. I
think Bjorn usually applies from patchwork so this'll likely be a
problem...
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index a6b9beb..96b5331 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -792,6 +792,11 @@ ap_spi_fp: &spi10 {
> #include <arm/cros-ec-sbs.dtsi>
>
> &uart3 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-1 = <&qup_uart3_sleep>;
> + interrupts-extended = <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>,
> + <&tlmm 41 IRQ_TYPE_EDGE_FALLING>;
> +
> status = "okay";
Same comments here as for patch #2.
> bluetooth: bluetooth {
> @@ -1345,4 +1350,47 @@ ap_spi_fp: &spi10 {
> drive-strength = <2>;
> };
> };
> +
> + qup_uart3_sleep: qup-uart3-sleep {
I believe things in this section are supposed to be sorted
alphabetically. Thus "qup..." should be sorted before "trackpad..."
On 2020-09-10 20:12, Doug Anderson wrote:
> Hi,
>
> On Thu, Sep 10, 2020 at 5:55 AM satya priya <[email protected]>
> wrote:
>>
>> Add a suitable sleep configuration for uart3 to support Bluetooth
>> wakeup.
>>
>> If QUP function is selected in sleep state, UART RTS/RFR is pulled
>> high
>> during suspend and BT SoC not able to send wakeup bytes. So, configure
>> GPIO mode in sleep state to keep it low during suspend.
>>
>> Signed-off-by: satya priya <[email protected]>
>> ---
>> Changes in V5:
>> - Newly added in V5. This patch adds wakeup support for trogdor board
>> files.
>>
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 48
>> ++++++++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>
> Note: I can't find this email on any of the mailing lists. Can you
> check your config? I tried:
>
> http://lore.kernel.org/r/[email protected]
>
> ...and also checked patchwork servers. I only see patch 1 and 2. I
> think Bjorn usually applies from patchwork so this'll likely be a
> problem...
>
I guess it is updated, now it is showing all the 4 patches
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=346637
>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> index a6b9beb..96b5331 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> @@ -792,6 +792,11 @@ ap_spi_fp: &spi10 {
>> #include <arm/cros-ec-sbs.dtsi>
>>
>> &uart3 {
>> + pinctrl-names = "default", "sleep";
>> + pinctrl-1 = <&qup_uart3_sleep>;
>> + interrupts-extended = <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>,
>> + <&tlmm 41 IRQ_TYPE_EDGE_FALLING>;
>> +
>> status = "okay";
>
> Same comments here as for patch #2.
>
Ok.
>
>> bluetooth: bluetooth {
>> @@ -1345,4 +1350,47 @@ ap_spi_fp: &spi10 {
>> drive-strength = <2>;
>> };
>> };
>> +
>> + qup_uart3_sleep: qup-uart3-sleep {
>
> I believe things in this section are supposed to be sorted
> alphabetically. Thus "qup..." should be sorted before "trackpad..."
Ok.