2013-09-04 07:00:09

by Sachin Kamat

[permalink] [raw]

Subject: [PATCH 1/1] regulator: s2mps11: Use devm_regulator_register

---

Commit e398b51a ("regulator: s2mps11: Convert to devm_regulator_register()")
intended to do this conversion. However the actual conversion to devm_* got
missed out. Fix this.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/regulator/s2mps11.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index 163b232..7a90a16 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -293,7 +293,8 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
config.init_data = pdata->regulators[i].initdata;
config.driver_data = s2mps11;

- s2mps11->rdev[i] = regulator_register(&regulators[i], &config);
+ s2mps11->rdev[i] = devm_regulator_register(&pdev->dev,
+ &regulators[i], &config);
if (IS_ERR(s2mps11->rdev[i])) {
ret = PTR_ERR(s2mps11->rdev[i]);
dev_err(&pdev->dev, "regulator init failed for %d\n",
--
1.7.9.5

2013-09-04 09:52:33

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH 1/1] regulator: s2mps11: Use devm_regulator_register

---

On Wed, Sep 04, 2013 at 12:12:15PM +0530, Sachin Kamat wrote:
> Commit e398b51a ("regulator: s2mps11: Convert to devm_regulator_register()")
> intended to do this conversion. However the actual conversion to devm_* got
> missed out. Fix this.

Applied, thanks.

---

Attachments:

(No filename) (261.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments

2013-09-04 23:59:57

by Sangbeom Kim

[permalink] [raw]

Subject: RE: [PATCH 1/1] regulator: s2mps11: Use devm_regulator_register

---

On Wednesday, September 04, 2013 3:42 PM, Sachin Kamat wrote:

> Commit e398b51a ("regulator: s2mps11: Convert to devm_regulator_register()")
> intended to do this conversion. However the actual conversion to devm_* got
> missed out. Fix this.
>

Acked-by: Sangbeom Kim <[email protected]>

Thanks,
Sangbeom.