2023-05-22 15:56:49

by Yan Yan(cailing)

Subject: [PATCH v2] sched/headers: remove duplicate included header files

These headers are included more than once, some also appear in
kernel/sched/sched.h, so remove them.

Signed-off-by: Yan Yan <[email protected]>
---
kernel/sched/build_utility.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
index 99bdd96f454f..b9ae5fe42f7b 100644
--- a/kernel/sched/build_utility.c
+++ b/kernel/sched/build_utility.c
@@ -13,16 +13,10 @@
#include <linux/sched/cputime.h>
#include <linux/sched/debug.h>
#include <linux/sched/isolation.h>
-#include <linux/sched/loadavg.h>
#include <linux/sched/nohz.h>
-#include <linux/sched/mm.h>
-#include <linux/sched/rseq_api.h>
#include <linux/sched/task_stack.h>

-#include <linux/cpufreq.h>
-#include <linux/cpumask_api.h>
#include <linux/cpuset.h>
-#include <linux/ctype.h>
#include <linux/debugfs.h>
#include <linux/energy_model.h>
#include <linux/hashtable_api.h>
@@ -32,18 +26,12 @@
#include <linux/mempolicy.h>
#include <linux/nmi.h>
#include <linux/nospec.h>
-#include <linux/proc_fs.h>
-#include <linux/psi.h>
-#include <linux/psi.h>
#include <linux/ptrace_api.h>
#include <linux/sched_clock.h>
#include <linux/security.h>
-#include <linux/spinlock_api.h>
#include <linux/swait_api.h>
#include <linux/timex.h>
#include <linux/utsname.h>
-#include <linux/wait_api.h>
-#include <linux/workqueue_api.h>

#include <uapi/linux/prctl.h>
#include <uapi/linux/sched/types.h>
--
2.40.0

2023-05-29 04:21:46

by Yan Yan(cailing)

Subject: Re: [PATCH v2] sched/headers: remove duplicate included header files

Ping, any comment?

thanks,

-Yan Yan

在 2023/5/22 23:53, Yan Yan(cailing) 写道:
> These headers are included more than once, some also appear in
> kernel/sched/sched.h, so remove them.
>
> Signed-off-by: Yan Yan <[email protected]>
> ---
> kernel/sched/build_utility.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
> index 99bdd96f454f..b9ae5fe42f7b 100644
> --- a/kernel/sched/build_utility.c
> +++ b/kernel/sched/build_utility.c
> @@ -13,16 +13,10 @@
> #include <linux/sched/cputime.h>
> #include <linux/sched/debug.h>
> #include <linux/sched/isolation.h>
> -#include <linux/sched/loadavg.h>
> #include <linux/sched/nohz.h>
> -#include <linux/sched/mm.h>
> -#include <linux/sched/rseq_api.h>
> #include <linux/sched/task_stack.h>
>
> -#include <linux/cpufreq.h>
> -#include <linux/cpumask_api.h>
> #include <linux/cpuset.h>
> -#include <linux/ctype.h>
> #include <linux/debugfs.h>
> #include <linux/energy_model.h>
> #include <linux/hashtable_api.h>
> @@ -32,18 +26,12 @@
> #include <linux/mempolicy.h>
> #include <linux/nmi.h>
> #include <linux/nospec.h>
> -#include <linux/proc_fs.h>
> -#include <linux/psi.h>
> -#include <linux/psi.h>
> #include <linux/ptrace_api.h>
> #include <linux/sched_clock.h>
> #include <linux/security.h>
> -#include <linux/spinlock_api.h>
> #include <linux/swait_api.h>
> #include <linux/timex.h>
> #include <linux/utsname.h>
> -#include <linux/wait_api.h>
> -#include <linux/workqueue_api.h>
>
> #include <uapi/linux/prctl.h>
> #include <uapi/linux/sched/types.h>

2023-05-29 07:03:14

by Mukesh Ojha

Subject: Re: [PATCH v2] sched/headers: remove duplicate included header files

On 5/22/2023 9:23 PM, Yan Yan(cailing) wrote:
> These headers are included more than once, some also appear in
> kernel/sched/sched.h, so remove them.
>
> Signed-off-by: Yan Yan <[email protected]>

Reviewed-by: Mukesh Ojha <[email protected]>

-- Mukesh

> ---
> kernel/sched/build_utility.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
> index 99bdd96f454f..b9ae5fe42f7b 100644
> --- a/kernel/sched/build_utility.c
> +++ b/kernel/sched/build_utility.c
> @@ -13,16 +13,10 @@
> #include <linux/sched/cputime.h>
> #include <linux/sched/debug.h>
> #include <linux/sched/isolation.h>
> -#include <linux/sched/loadavg.h>
> #include <linux/sched/nohz.h>
> -#include <linux/sched/mm.h>
> -#include <linux/sched/rseq_api.h>
> #include <linux/sched/task_stack.h>
>
> -#include <linux/cpufreq.h>
> -#include <linux/cpumask_api.h>
> #include <linux/cpuset.h>
> -#include <linux/ctype.h>
> #include <linux/debugfs.h>
> #include <linux/energy_model.h>
> #include <linux/hashtable_api.h>
> @@ -32,18 +26,12 @@
> #include <linux/mempolicy.h>
> #include <linux/nmi.h>
> #include <linux/nospec.h>
> -#include <linux/proc_fs.h>
> -#include <linux/psi.h>
> -#include <linux/psi.h>
> #include <linux/ptrace_api.h>
> #include <linux/sched_clock.h>
> #include <linux/security.h>
> -#include <linux/spinlock_api.h>
> #include <linux/swait_api.h>
> #include <linux/timex.h>
> #include <linux/utsname.h>
> -#include <linux/wait_api.h>
> -#include <linux/workqueue_api.h>
>
> #include <uapi/linux/prctl.h>
> #include <uapi/linux/sched/types.h>