Use the new SNOR_ID3() so we don't have to specify the number of sectors
as we are reading that property from the SFDP anyways.
Signed-off-by: Michael Walle <[email protected]>
---
drivers/mtd/spi-nor/winbond.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 08f9b5abf4d2..12b38f6776f4 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -134,8 +134,7 @@ static const struct flash_info winbond_nor_parts[] = {
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
SPI_NOR_DUAL_READ) },
- { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
- PARSE_SFDP
+ { "w25q512nwm", SNOR_ID3(0xef8020)
OTP_INFO(256, 3, 0x1000, 0x1000) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
--
2.30.2
Shaik, can we have your Tested-by tag on this?
Thanks,
ta
Am 2022-07-12 10:40, schrieb [email protected]:
> Shaik, can we have your Tested-by tag on this?
This will need the following patch to work correctly:
https://lore.kernel.org/linux-mtd/[email protected]/
But other that that, the SFDP data is exactly the same
as in the w25q512nwq, except for the "hello world" string.
But that string is between the header and the tables in
an unused area and I suspect it was accidentally written
during OTP testing as it happend with the w25q512nwq, too.
So this should be good to go once the w25q512nwq is merged.
-michael
Am 2022-07-12 10:40, schrieb [email protected]:
> Shaik, can we have your Tested-by tag on this?
Sigh. His email address bounces with "The email address you
entered couldn't be found." So don't expect a Tested-by: here.
-michael
On 7/18/22 10:25, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Am 2022-07-12 10:40, schrieb [email protected]:
>> Shaik, can we have your Tested-by tag on this?
>
> Sigh. His email address bounces with "The email address you
> entered couldn't be found." So don't expect a Tested-by: here.
>
Would you drop this and pick the other patches that use your SNOR_ID3
and submit them all in a single patch set?
Am 2022-07-19 08:00, schrieb [email protected]:
> On 7/18/22 10:25, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the content is safe
>>
>> Am 2022-07-12 10:40, schrieb [email protected]:
>>> Shaik, can we have your Tested-by tag on this?
>>
>> Sigh. His email address bounces with "The email address you
>> entered couldn't be found." So don't expect a Tested-by: here.
>>
>
> Would you drop this and pick the other patches that use your SNOR_ID3
> and submit them all in a single patch set?
I can collect the other patches, but why drop this if we know
for a fact that the flash will work? (Because it is the same
as the w25q512nwq)
-michael
On 7/19/22 10:02, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Am 2022-07-19 08:00, schrieb [email protected]:
>> On 7/18/22 10:25, Michael Walle wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>>> the content is safe
>>>
>>> Am 2022-07-12 10:40, schrieb [email protected]:
>>>> Shaik, can we have your Tested-by tag on this?
>>>
>>> Sigh. His email address bounces with "The email address you
>>> entered couldn't be found." So don't expect a Tested-by: here.
>>>
>>
>> Would you drop this and pick the other patches that use your SNOR_ID3
>> and submit them all in a single patch set?
>
> I can collect the other patches, but why drop this if we know
> for a fact that the flash will work? (Because it is the same
> as the w25q512nwq)
>
Was it tested? I don't mind to queue it, but I thought we only queue
changes that were tested on actual hw.