2010-06-02 09:01:02

by Hemanth V

[permalink] [raw]
Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

----- Original Message -----
From: "Andrew Morton" <[email protected]>
To: "Jonathan Cameron" <[email protected]>
Cc: "Hemanth V" <[email protected]>; <[email protected]>;
<[email protected]>; "Daniel Mack" <[email protected]>; "Jonathan
Cameron" <[email protected]>; "Wolfram Sang" <[email protected]>
Sent: Wednesday, June 02, 2010 2:24 AM
Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver


> On Tue, 01 Jun 2010 21:39:10 +0100
> Jonathan Cameron <[email protected]> wrote:
>
>> >
>> > It would be most useful if the changelog were to fully describe the
>> > proposed kernel<->userspace interface. That's the most important part
>> > of the driver, because it's the only part we can never change.
>> >
>> > There is a desultory effort to maintain sysfs API descriptions under
>> > Documentation/ABI/. I'd have thought that it would be appropriate to
>> > document this driver's ABI in there.
>> Agreed, but we get back to the debate of what we should standardise on.
>
> I'd suggest standardising on one of the existing drivers. That way we
> have two compliant drivers and only need to change (n-2) others. If we
> pick some new standard then we need to change (n) drivers.
>

Currently this driver follows the same sysfs convention as supported
by isl29003.c in drivers/misc.