2023-03-08 13:19:38

by Geert Uytterhoeven

Subject: [PATCH v3] net: ethernet: ti: am65-cpsw: Convert to devm_of_phy_optional_get()

Use the new devm_of_phy_optional_get() helper instead of open-coding the
same operation.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Siddharth Vadapalli <[email protected]>
---
v3:
- Add Reviewed-by,

v2:
- Rebase on top of commit 854617f52ab42418 ("net: ethernet: ti:
am65-cpsw: Handle -EPROBE_DEFER for Serdes PHY") in net-next
(next-20230123 and later).
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 4e3861c47708c9e2..25996826edabc019 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1470,11 +1470,9 @@ static int am65_cpsw_init_serdes_phy(struct device *dev, struct device_node *por
struct phy *phy;
int ret;

- phy = devm_of_phy_get(dev, port_np, name);
- if (PTR_ERR(phy) == -ENODEV)
- return 0;
- if (IS_ERR(phy))
- return PTR_ERR(phy);
+ phy = devm_of_phy_optional_get(dev, port_np, name);
+ if (IS_ERR_OR_NULL(phy))
+ return PTR_ERR_OR_ZERO(phy);

/* Serdes PHY exists. Store it. */
port->slave.serdes_phy = phy;
--
2.34.1

2023-03-09 13:33:27

by Simon Horman

Subject: Re: [PATCH v3] net: ethernet: ti: am65-cpsw: Convert to devm_of_phy_optional_get()

On Wed, Mar 08, 2023 at 02:04:52PM +0100, Geert Uytterhoeven wrote:
> Use the new devm_of_phy_optional_get() helper instead of open-coding the
> same operation.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Reviewed-by: Siddharth Vadapalli <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-03-10 07:30:34

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v3] net: ethernet: ti: am65-cpsw: Convert to devm_of_phy_optional_get()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 8 Mar 2023 14:04:52 +0100 you wrote:
> Use the new devm_of_phy_optional_get() helper instead of open-coding the
> same operation.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Reviewed-by: Siddharth Vadapalli <[email protected]>
> ---
> v3:
> - Add Reviewed-by,
>
> [...]

Here is the summary with links:
- [v3] net: ethernet: ti: am65-cpsw: Convert to devm_of_phy_optional_get()
https://git.kernel.org/netdev/net-next/c/b3a8df9f27c0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html