2024-03-30 20:33:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 00/11] drm/exynos: drop driver owner initialization

Simplify the code by dropping unnecessary .owner initialization in the
driver.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (11):
drm/exynos: fimc: drop driver owner initialization
drm/exynos: fimd: drop driver owner initialization
drm/exynos: dsi: drop driver owner initialization
drm/exynos: g2d: drop driver owner initialization
drm/exynos: gsc: drop driver owner initialization
drm/exynos: mic: drop driver owner initialization
drm/exynos: rotator: drop driver owner initialization
drm/exynos: scaler: drop driver owner initialization
drm/exynos: vidi: drop driver owner initialization
drm/exynos: hdmi: drop driver owner initialization
drm/exynos: mixer: drop driver owner initialization

drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_mic.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 1 -
drivers/gpu/drm/exynos/exynos_hdmi.c | 1 -
drivers/gpu/drm/exynos/exynos_mixer.c | 1 -
11 files changed, 11 deletions(-)
---
base-commit: 7fdcff3312e16ba8d1419f8a18f465c5cc235ecf
change-id: 20240330-b4-module-owner-drm-exynos-d2f1b2d48af3

Best regards,
--
Krzysztof Kozlowski <[email protected]>



2024-03-30 20:33:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 01/11] drm/exynos: fimc: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index e81a576de398..142184c8c3bc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
@@ -1412,7 +1412,6 @@ struct platform_driver fimc_driver = {
.driver = {
.of_match_table = fimc_of_match,
.name = "exynos-drm-fimc",
- .owner = THIS_MODULE,
.pm = pm_ptr(&fimc_pm_ops),
},
};

--
2.34.1


2024-03-30 20:33:50

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 02/11] drm/exynos: fimd: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index f2145227a1e0..f57df8c48139 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -1326,7 +1326,6 @@ struct platform_driver fimd_driver = {
.remove_new = fimd_remove,
.driver = {
.name = "exynos4-fb",
- .owner = THIS_MODULE,
.pm = pm_ptr(&exynos_fimd_pm_ops),
.of_match_table = fimd_driver_dt_match,
},

--
2.34.1


2024-03-30 20:34:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 04/11] drm/exynos: g2d: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index f3138423612e..3a3b2c00e400 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -1610,7 +1610,6 @@ struct platform_driver g2d_driver = {
.remove_new = g2d_remove,
.driver = {
.name = "exynos-drm-g2d",
- .owner = THIS_MODULE,
.pm = pm_ptr(&g2d_pm_ops),
.of_match_table = exynos_g2d_match,
},

--
2.34.1


2024-03-30 20:34:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 03/11] drm/exynos: dsi: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 2fe0e5f3f638..bf16deaae68b 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -184,7 +184,6 @@ struct platform_driver dsi_driver = {
.remove_new = samsung_dsim_remove,
.driver = {
.name = "exynos-dsi",
- .owner = THIS_MODULE,
.pm = &samsung_dsim_pm_ops,
.of_match_table = exynos_dsi_of_match,
},

--
2.34.1


2024-03-30 20:34:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 06/11] drm/exynos: mic: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index e2920960180f..d61ec451807c 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -464,7 +464,6 @@ struct platform_driver mic_driver = {
.driver = {
.name = "exynos-mic",
.pm = pm_ptr(&exynos_mic_pm_ops),
- .owner = THIS_MODULE,
.of_match_table = exynos_mic_of_match,
},
};

--
2.34.1


2024-03-30 20:34:49

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 05/11] drm/exynos: gsc: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index 180507a47700..1b111e2c3347 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
@@ -1423,7 +1423,6 @@ struct platform_driver gsc_driver = {
.remove_new = gsc_remove,
.driver = {
.name = "exynos-drm-gsc",
- .owner = THIS_MODULE,
.pm = &gsc_pm_ops,
.of_match_table = exynos_drm_gsc_of_match,
},

--
2.34.1


2024-03-30 20:34:54

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 07/11] drm/exynos: rotator: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c
index 5f7516655b08..2eb0b701672f 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c
@@ -454,7 +454,6 @@ struct platform_driver rotator_driver = {
.remove_new = rotator_remove,
.driver = {
.name = "exynos-rotator",
- .owner = THIS_MODULE,
.pm = pm_ptr(&rotator_pm_ops),
.of_match_table = exynos_rotator_match,
},

--
2.34.1


2024-03-30 20:35:06

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 08/11] drm/exynos: scaler: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c
index 392f721f13ab..a9d469896824 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c
@@ -722,7 +722,6 @@ struct platform_driver scaler_driver = {
.remove_new = scaler_remove,
.driver = {
.name = "exynos-scaler",
- .owner = THIS_MODULE,
.pm = pm_ptr(&scaler_pm_ops),
.of_match_table = exynos_scaler_match,
},

--
2.34.1


2024-03-30 20:35:21

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 09/11] drm/exynos: vidi: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
index f5bbba9ad225..fab135308b70 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
@@ -479,7 +479,6 @@ struct platform_driver vidi_driver = {
.remove_new = vidi_remove,
.driver = {
.name = "exynos-drm-vidi",
- .owner = THIS_MODULE,
.dev_groups = vidi_groups,
},
};

--
2.34.1


2024-03-30 20:35:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 10/11] drm/exynos: hdmi: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index b1d02dec3774..5fdeec8a3875 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -2126,7 +2126,6 @@ struct platform_driver hdmi_driver = {
.remove_new = hdmi_remove,
.driver = {
.name = "exynos-hdmi",
- .owner = THIS_MODULE,
.pm = &exynos_hdmi_pm_ops,
.of_match_table = hdmi_match_types,
},

--
2.34.1


2024-03-30 20:35:48

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 11/11] drm/exynos: mixer: drop driver owner initialization

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_mixer.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index 6822333fd0e6..1db955f00044 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -1331,7 +1331,6 @@ static const struct dev_pm_ops exynos_mixer_pm_ops = {
struct platform_driver mixer_driver = {
.driver = {
.name = "exynos-mixer",
- .owner = THIS_MODULE,
.pm = &exynos_mixer_pm_ops,
.of_match_table = mixer_match_types,
},

--
2.34.1


Subject: RE: [PATCH 00/11] drm/exynos: drop driver owner initialization

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Sunday, March 31, 2024 5:33 AM
> To: Inki Dae <[email protected]>; Seung-Woo Kim
> <[email protected]>; Kyungmin Park <[email protected]>; David
> Airlie <[email protected]>; Daniel Vetter <[email protected]>; Krzysztof
> Kozlowski <[email protected]>; Alim Akhtar
> <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH 00/11] drm/exynos: drop driver owner initialization
>
> Simplify the code by dropping unnecessary .owner initialization in the
> driver.

Applied.

Thanks. :)
Inki Dae

>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (11):
> drm/exynos: fimc: drop driver owner initialization
> drm/exynos: fimd: drop driver owner initialization
> drm/exynos: dsi: drop driver owner initialization
> drm/exynos: g2d: drop driver owner initialization
> drm/exynos: gsc: drop driver owner initialization
> drm/exynos: mic: drop driver owner initialization
> drm/exynos: rotator: drop driver owner initialization
> drm/exynos: scaler: drop driver owner initialization
> drm/exynos: vidi: drop driver owner initialization
> drm/exynos: hdmi: drop driver owner initialization
> drm/exynos: mixer: drop driver owner initialization
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 -
> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 1 -
> drivers/gpu/drm/exynos/exynos_hdmi.c | 1 -
> drivers/gpu/drm/exynos/exynos_mixer.c | 1 -
> 11 files changed, 11 deletions(-)
> ---
> base-commit: 7fdcff3312e16ba8d1419f8a18f465c5cc235ecf
> change-id: 20240330-b4-module-owner-drm-exynos-d2f1b2d48af3
>
> Best regards,
> --
> Krzysztof Kozlowski <[email protected]>
>