2020-11-21 19:43:23

by Masahiro Yamada

Subject: [PATCH 0/6] ARC: build: fix various issues in arc boot Makefile

Masahiro Yamada (6):
ARC: build: remove non-existing bootpImage from KBUILD_IMAGE
ARC: build: add uImage.lzma to the top-level target
ARC: build: add boot_targets to PHONY
ARC: build: move symlink creation to arch/arc/Makefile to avoid race
ARC: build: remove unneeded extra-y
ARC: build: use $(READELF) instead of hard-coded readelf

arch/arc/Makefile | 20 +++++++++++++-------
arch/arc/boot/Makefile | 18 ++++--------------
2 files changed, 17 insertions(+), 21 deletions(-)

--
2.25.1

2020-11-21 19:43:58

by Masahiro Yamada

Subject: [PATCH 2/6] ARC: build: add uImage.lzma to the top-level target

arch/arc/boot/Makefile supports uImage.lzma, but you cannot do
'make uImage.lzma' because the corresponding target is missing
in arch/arc/Makefile. Add it.

I also changed the assignment operator '+=' to ':=' since this is the
only place where we expect this variable to be set.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/arc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/Makefile b/arch/arc/Makefile
index acf99420e161..61a41123ad4c 100644
--- a/arch/arc/Makefile
+++ b/arch/arc/Makefile
@@ -102,7 +102,7 @@ libs-y += arch/arc/lib/ $(LIBGCC)

boot := arch/arc/boot

-boot_targets += uImage uImage.bin uImage.gz
+boot_targets := uImage uImage.bin uImage.gz uImage.lzma

$(boot_targets): vmlinux
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
--
2.25.1

2020-11-25 04:43:54

by Vineet Gupta

Subject: Re: [PATCH 0/6] ARC: build: fix various issues in arc boot Makefile

Hi Masahiro San,

On 11/21/20 11:36 AM, Masahiro Yamada wrote:
>
>
> Masahiro Yamada (6):
> ARC: build: remove non-existing bootpImage from KBUILD_IMAGE
> ARC: build: add uImage.lzma to the top-level target
> ARC: build: add boot_targets to PHONY
> ARC: build: move symlink creation to arch/arc/Makefile to avoid race
> ARC: build: remove unneeded extra-y
> ARC: build: use $(READELF) instead of hard-coded readelf
>
> arch/arc/Makefile | 20 +++++++++++++-------
> arch/arc/boot/Makefile | 18 ++++--------------
> 2 files changed, 17 insertions(+), 21 deletions(-)

This LGTM. Do you want me to pick up these via ARC tree ?

Thx,
-Vineet

2020-12-01 12:34:09

by Masahiro Yamada

Subject: Re: [PATCH 0/6] ARC: build: fix various issues in arc boot Makefile

On Wed, Nov 25, 2020 at 1:40 PM Vineet Gupta <[email protected]> wrote:
>
> Hi Masahiro San,
>
> On 11/21/20 11:36 AM, Masahiro Yamada wrote:
> >
> >
> > Masahiro Yamada (6):
> > ARC: build: remove non-existing bootpImage from KBUILD_IMAGE
> > ARC: build: add uImage.lzma to the top-level target
> > ARC: build: add boot_targets to PHONY
> > ARC: build: move symlink creation to arch/arc/Makefile to avoid race
> > ARC: build: remove unneeded extra-y
> > ARC: build: use $(READELF) instead of hard-coded readelf
> >
> > arch/arc/Makefile | 20 +++++++++++++-------
> > arch/arc/boot/Makefile | 18 ++++--------------
> > 2 files changed, 17 insertions(+), 21 deletions(-)
>
> This LGTM. Do you want me to pick up these via ARC tree ?
>
> Thx,
> -Vineet

Yes, please. Thanks.




--
Best Regards
Masahiro Yamada