2017-03-05 00:02:56

by Alexey Khoroshilov

Subject: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <[email protected]>
---
net/sched/act_skbmod.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e23024..c736627f8f4a 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c
@@ -228,7 +228,6 @@ static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,

return skb->len;
nla_put_failure:
- rcu_read_unlock();
nlmsg_trim(skb, b);
return -1;
}
--
2.7.4

2017-03-05 02:21:43

by Jamal Hadi Salim

Subject: Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

On 17-03-04 07:01 PM, Alexey Khoroshilov wrote:
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <[email protected]>

Acked-by: Jamal Hadi Salim <[email protected]>

cheers,
jamal

2017-03-07 22:41:27

by David Miller

Subject: Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

From: Alexey Khoroshilov <[email protected]>
Date: Sun, 5 Mar 2017 03:01:55 +0300

> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <[email protected]>

Applied and queued up for -stable, thanks.