On 08. nov. 2017 18:19, Vivien Didelot wrote:
> The DSA switch MDB ops pass the switchdev_trans structure down to the
> drivers, but no one is using them and they aren't supposed to anyway.
>
> Remove the trans argument from MDB prepare and add operations.
>
> - int (*port_mdb_prepare)(struct dsa_switch *ds, int port,
> - const struct switchdev_obj_port_mdb *mdb,
> - struct switchdev_trans *trans);
> - void (*port_mdb_add)(struct dsa_switch *ds, int port,
> - const struct switchdev_obj_port_mdb *mdb,
> - struct switchdev_trans *trans);
> + int (*port_mdb_prepare)(struct dsa_switch *ds, int port,
> + const struct switchdev_obj_port_mdb *mdb);
> + void (*port_mdb_add)(struct dsa_switch *ds, int port,
> + const struct switchdev_obj_port_mdb *mdb);
> int (*port_mdb_del)(struct dsa_switch *ds, int port,
> const struct switchdev_obj_port_mdb *mdb);
Hi Vivien
Nice to get rid of "trans". I recall I was confused by this parameter.
"Am I supposed to do something with this parameter?".
But when at it. What about getting rid of switchdev_obj_port_mdb, making
similar signatures as the new .port_fdb_xxx functions? Would that make
sense?
Egil
From 1583519247280642413@xxx Wed Nov 08 17:20:35 +0000 2017
X-GM-THRID: 1583519247280642413
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread