2017-11-03 13:18:45

by Alex Elder

[permalink] [raw]
Subject: Re: [PATCH] soc: qcom: remove unused label

On 10/18/2017 03:30 AM, Arnd Bergmann wrote:
> The newly added driver comes with a harmless warning:
>
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
>
> This removes the unused label to avoid the warning.
>
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <[email protected]>

Looks good.

Reviewed-by: Alex Elder <[email protected]>

> ---
> drivers/soc/qcom/rmtfs_mem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index f6f2f0cb3b3a..ce35ff748adf 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>
> return 0;
>
> -remove_cdev:
> - cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
> put_device:
> put_device(&rmtfs_mem->dev);
>
>


From 1583047774194822107@xxx Fri Nov 03 12:26:43 +0000 2017
X-GM-THRID: 1581601965543833240
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread