2020-01-27 23:57:24

by Brendan Higgins

Subject: [PATCH v1 2/5] reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency

Currently CONFIG_RESET_BRCMSTB_RESCAL=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

/usr/bin/ld: drivers/reset/reset-brcmstb-rescal.o: in function `brcm_rescal_reset_probe':
drivers/reset/reset-brcmstb-rescal.c:76: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Signed-off-by: Brendan Higgins <[email protected]>
---
drivers/reset/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 461b0e506a26f..a19bd303f31a9 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -51,6 +51,7 @@ config RESET_BRCMSTB

config RESET_BRCMSTB_RESCAL
bool "Broadcom STB RESCAL reset controller"
+ depends on HAS_IOMEM
default ARCH_BRCMSTB || COMPILE_TEST
help
This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
--
2.25.0.341.g760bfbb309-goog

2020-01-28 09:44:05

by Philipp Zabel

Subject: Re: [PATCH v1 2/5] reset: brcmstb-rescal: add unspecified HAS_IOMEM dependency

On Mon, 2020-01-27 at 15:53 -0800, Brendan Higgins wrote:
> Currently CONFIG_RESET_BRCMSTB_RESCAL=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> /usr/bin/ld: drivers/reset/reset-brcmstb-rescal.o: in function `brcm_rescal_reset_probe':
> drivers/reset/reset-brcmstb-rescal.c:76: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Signed-off-by: Brendan Higgins <[email protected]>
> ---
> drivers/reset/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 461b0e506a26f..a19bd303f31a9 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -51,6 +51,7 @@ config RESET_BRCMSTB
>
> config RESET_BRCMSTB_RESCAL
> bool "Broadcom STB RESCAL reset controller"
> + depends on HAS_IOMEM
> default ARCH_BRCMSTB || COMPILE_TEST
> help
> This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on

Thank you, I'll pick up the reset patches 2 and 3.

regards
Philipp