2022-04-01 14:53:27

by Krzysztof Kozlowski

Subject: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

The 'struct device' pointer is already cached as local variable in
ufshcd_pltfrm_init(), so use it.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 87975d1a21c8..cca4b2181a81 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -341,7 +341,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,

err = ufshcd_alloc_host(dev, &hba);
if (err) {
- dev_err(&pdev->dev, "Allocation failed\n");
+ dev_err(dev, "Allocation failed\n");
goto out;
}

@@ -349,13 +349,13 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,

err = ufshcd_parse_clock_info(hba);
if (err) {
- dev_err(&pdev->dev, "%s: clock parse failed %d\n",
+ dev_err(dev, "%s: clock parse failed %d\n",
__func__, err);
goto dealloc_host;
}
err = ufshcd_parse_regulator_info(hba);
if (err) {
- dev_err(&pdev->dev, "%s: regulator init failed %d\n",
+ dev_err(dev, "%s: regulator init failed %d\n",
__func__, err);
goto dealloc_host;
}
@@ -368,8 +368,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
goto dealloc_host;
}

- pm_runtime_set_active(&pdev->dev);
- pm_runtime_enable(&pdev->dev);
+ pm_runtime_set_active(dev);
+ pm_runtime_enable(dev);

return 0;

--
2.32.0

2022-04-02 15:55:03

by Chanho Park

Subject: RE: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Friday, April 1, 2022 5:51 PM
> To: Alim Akhtar <[email protected]>; Avri Altman
> <[email protected]>; James E.J. Bottomley <[email protected]>; Martin
K.
> Petersen <[email protected]>; [email protected]; linux-
> [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>
> Subject: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev
>
> The 'struct device' pointer is already cached as local variable in
> ufshcd_pltfrm_init(), so use it.

Reviewed-by: Chanho Park <[email protected]>

Best Regards,
Chanho Park

>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd-pltfrm.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-
> pltfrm.c
> index 87975d1a21c8..cca4b2181a81 100644
> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
> @@ -341,7 +341,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
>
> err = ufshcd_alloc_host(dev, &hba);
> if (err) {
> - dev_err(&pdev->dev, "Allocation failed\n");
> + dev_err(dev, "Allocation failed\n");
> goto out;
> }
>
> @@ -349,13 +349,13 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
>
> err = ufshcd_parse_clock_info(hba);
> if (err) {
> - dev_err(&pdev->dev, "%s: clock parse failed %d\n",
> + dev_err(dev, "%s: clock parse failed %d\n",
> __func__, err);
> goto dealloc_host;
> }
> err = ufshcd_parse_regulator_info(hba);
> if (err) {
> - dev_err(&pdev->dev, "%s: regulator init failed %d\n",
> + dev_err(dev, "%s: regulator init failed %d\n",
> __func__, err);
> goto dealloc_host;
> }
> @@ -368,8 +368,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
> goto dealloc_host;
> }
>
> - pm_runtime_set_active(&pdev->dev);
> - pm_runtime_enable(&pdev->dev);
> + pm_runtime_set_active(dev);
> + pm_runtime_enable(dev);
>
> return 0;
>
> --
> 2.32.0

2022-04-07 09:39:19

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: ufshcd-pltfrm: simplify usages of pdev->dev

Krzysztof,

> The 'struct device' pointer is already cached as local variable in
> ufshcd_pltfrm_init(), so use it.

Applied to 5.19/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering