2022-05-17 20:58:55

by Smitha T Murthy

Subject: [PATCH 03/20] dt-bindings: media: s5p-mfc: Add mfcv12 variant

Adds DT schema for s5p-mfc with a new compatible
string for mfcv12 variant.

Cc: [email protected]
Signed-off-by: Smitha T Murthy <[email protected]>
---
Documentation/devicetree/bindings/media/s5p-mfc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.yaml b/Documentation/devicetree/bindings/media/s5p-mfc.yaml
index fff7c7e0d575..209da53f3582 100644
--- a/Documentation/devicetree/bindings/media/s5p-mfc.yaml
+++ b/Documentation/devicetree/bindings/media/s5p-mfc.yaml
@@ -21,6 +21,7 @@ properties:
- samsung,mfc-v8 # Exynos5800
- samsung,exynos5433-mfc # Exynos5433
- samsung,mfc-v10 # Exynos7880
+ - samsung,mfc-v12 # Tesla FSD

reg:
maxItems: 1
--
2.17.1

2022-05-18 01:43:57

by Krzysztof Kozlowski

Subject: Re: [PATCH 03/20] dt-bindings: media: s5p-mfc: Add mfcv12 variant

On 17/05/2022 14:55, Smitha T Murthy wrote:
> Adds DT schema for s5p-mfc with a new compatible
> string for mfcv12 variant.
>
> Cc: [email protected]
> Signed-off-by: Smitha T Murthy <[email protected]>
> ---
> Documentation/devicetree/bindings/media/s5p-mfc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.yaml b/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> index fff7c7e0d575..209da53f3582 100644
> --- a/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> @@ -21,6 +21,7 @@ properties:
> - samsung,mfc-v8 # Exynos5800
> - samsung,exynos5433-mfc # Exynos5433
> - samsung,mfc-v10 # Exynos7880
> + - samsung,mfc-v12 # Tesla FSD

No. We moved already to SoC specific comaptibles. You introduced back
wrong pattern with MFCv10, but it should be rather fixed. Don't go back
to it...

Best regards,
Krzysztof

2022-07-05 11:56:03

by Smitha T Murthy

Subject: RE: [PATCH 03/20] dt-bindings: media: s5p-mfc: Add mfcv12 variant

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: Tuesday, May 17, 2022 7:28 PM
> To: Smitha T Murthy <[email protected]>; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH 03/20] dt-bindings: media: s5p-mfc: Add mfcv12 variant
>
> On 17/05/2022 14:55, Smitha T Murthy wrote:
> > Adds DT schema for s5p-mfc with a new compatible string for mfcv12
> > variant.
> >
> > Cc: [email protected]
> > Signed-off-by: Smitha T Murthy <[email protected]>
> > ---
> > Documentation/devicetree/bindings/media/s5p-mfc.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> > b/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> > index fff7c7e0d575..209da53f3582 100644
> > --- a/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> > +++ b/Documentation/devicetree/bindings/media/s5p-mfc.yaml
> > @@ -21,6 +21,7 @@ properties:
> > - samsung,mfc-v8 # Exynos5800
> > - samsung,exynos5433-mfc # Exynos5433
> > - samsung,mfc-v10 # Exynos7880
> > + - samsung,mfc-v12 # Tesla FSD
>
> No. We moved already to SoC specific comaptibles. You introduced back
> wrong pattern with MFCv10, but it should be rather fixed. Don't go back to
> it...
>
> Best regards,
> Krzysztof

Sure, I will add SoC based compatible for MFCv12 in the next series.

Regards,
Smitha