2023-07-13 15:40:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)

The davicom,dm9000 Ethernet Controller accepts two reg addresses.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/samsung/s3c6410-mini6410.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
index 17097da36f5e..0b07b3c31960 100644
--- a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
+++ b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
@@ -51,7 +51,7 @@ srom-cs1-bus@18000000 {

ethernet@18000000 {
compatible = "davicom,dm9000";
- reg = <0x18000000 0x2 0x18000004 0x2>;
+ reg = <0x18000000 0x2>, <0x18000004 0x2>;
interrupt-parent = <&gpn>;
interrupts = <7 IRQ_TYPE_LEVEL_HIGH>;
davicom,no-eeprom;
--
2.34.1



2023-07-13 16:07:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet reg addresses (split)

The davicom,dm9000 Ethernet Controller accepts two reg addresses.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
index 6e26c67e0a26..901e7197b136 100644
--- a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
+++ b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
@@ -41,7 +41,7 @@ pmic_ap_clk: clock-0 {

ethernet@a8000000 {
compatible = "davicom,dm9000";
- reg = <0xA8000000 0x2 0xA8000002 0x2>;
+ reg = <0xa8000000 0x2>, <0xa8000002 0x2>;
interrupt-parent = <&gph1>;
interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
local-mac-address = [00 00 de ad be ef];
--
2.34.1


2023-07-14 11:40:56

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet reg addresses (split)



> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Thursday, July 13, 2023 8:59 PM
> To: Krzysztof Kozlowski <[email protected]>; Alim Akhtar
> <[email protected]>; Rob Herring <[email protected]>; Conor
> Dooley <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH 2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet
> reg addresses (split)
>
> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Do you need to add fixes: to send to previous stable releases?
In any case:
Reviewed-by: Alim Akhtar <[email protected]>


> arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> index 6e26c67e0a26..901e7197b136 100644
> --- a/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> +++ b/arch/arm/boot/dts/samsung/s5pv210-smdkv210.dts
> @@ -41,7 +41,7 @@ pmic_ap_clk: clock-0 {
>
> ethernet@a8000000 {
> compatible = "davicom,dm9000";
> - reg = <0xA8000000 0x2 0xA8000002 0x2>;
> + reg = <0xa8000000 0x2>, <0xa8000002 0x2>;
> interrupt-parent = <&gph1>;
> interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> local-mac-address = [00 00 de ad be ef];
> --
> 2.34.1



2023-07-14 11:43:05

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)

Hello Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Thursday, July 13, 2023 8:59 PM
> To: Krzysztof Kozlowski <[email protected]>; Alim Akhtar
> <[email protected]>; Rob Herring <[email protected]>; Conor
> Dooley <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet
> reg addresses (split)
>
> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Do you need to add fixes: to send to previous stable releases?
In any case:

Reviewed-by: Alim Akhtar <[email protected]>

> arch/arm/boot/dts/samsung/s3c6410-mini6410.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> index 17097da36f5e..0b07b3c31960 100644
> --- a/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> +++ b/arch/arm/boot/dts/samsung/s3c6410-mini6410.dts
> @@ -51,7 +51,7 @@ srom-cs1-bus@18000000 {
>
> ethernet@18000000 {
> compatible = "davicom,dm9000";
> - reg = <0x18000000 0x2 0x18000004 0x2>;
> + reg = <0x18000000 0x2>, <0x18000004 0x2>;
> interrupt-parent = <&gpn>;
> interrupts = <7 IRQ_TYPE_LEVEL_HIGH>;
> davicom,no-eeprom;
> --
> 2.34.1



2023-07-16 18:27:40

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)

On 14/07/2023 12:26, Alim Akhtar wrote:
> Hello Krzysztof
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <[email protected]>
>> Sent: Thursday, July 13, 2023 8:59 PM
>> To: Krzysztof Kozlowski <[email protected]>; Alim Akhtar
>> <[email protected]>; Rob Herring <[email protected]>; Conor
>> Dooley <[email protected]>; [email protected]; linux-
>> [email protected]; [email protected]; linux-
>> [email protected]
>> Subject: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet
>> reg addresses (split)
>>
>> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
> Do you need to add fixes: to send to previous stable releases?
> In any case:


The format was actually working, but indeed it makes sense to backport
it. I'll add it when applying.

Best regards,
Krzysztof


2023-07-19 07:40:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)


On Thu, 13 Jul 2023 17:29:25 +0200, Krzysztof Kozlowski wrote:
> The davicom,dm9000 Ethernet Controller accepts two reg addresses.
>
>

Applied, thanks!

[1/2] ARM: dts: samsung: s3c6410-mini6410: correct ethernet reg addresses (split)
https://git.kernel.org/krzk/linux/c/cf0cb2af6a18f28b84f9f1416bff50ca60d6e98a
[2/2] ARM: dts: samsung: s5pv210-smdkv210: correct ethernet reg addresses (split)
https://git.kernel.org/krzk/linux/c/982655cb0e7f18934d7532c32366e574ad61dbd7

Best regards,
--
Krzysztof Kozlowski <[email protected]>