2023-06-11 11:52:38

by Nils Kruse

Subject: [PATCH] nvme-pci: Add quirk for Samsung PM9B1 256G and 512G SSD

Add a quirk for Samsung PM9B1 256G and 512G that reports duplicate ids
for disk.

Signed-off-by: Nils Kruse <[email protected]>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 60f51155a6d2..de5e4c7e4bc9 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3395,7 +3395,8 @@ static const struct pci_device_id nvme_id_table[] = {
     { PCI_DEVICE(0x1d97, 0x2263),   /* SPCC */
         .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
     { PCI_DEVICE(0x144d, 0xa80b),   /* Samsung PM9B1 256G and 512G */
-        .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+        .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES |
+                NVME_QUIRK_BOGUS_NID, },
     { PCI_DEVICE(0x144d, 0xa809),   /* Samsung MZALQ256HBJD 256G */
         .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
     { PCI_DEVICE(0x1cc4, 0x6303),   /* UMIS RPJTJ512MGE1QDY 512G */
--
2.41.0

2023-07-16 19:54:11

by August Wikerfors

Subject: Re: [PATCH] nvme-pci: Add quirk for Samsung PM9B1 256G and 512G SSD

On 2023-06-11 13:41, Nils Kruse wrote:
> Add a quirk for Samsung PM9B1 256G and 512G that reports duplicate ids
> for disk.

Is this the same issue with suspend as [1], [2] and [3] or is it a
different case?

[1] https://lore.kernel.org/all/[email protected]/t/
[2] https://github.com/tomsom/yoga-linux/issues/9
[3] https://lore.kernel.org/all/[email protected]/

2023-07-17 08:31:44

by Nils Kruse

Subject: Re: [PATCH] nvme-pci: Add quirk for Samsung PM9B1 256G and 512G SSD

On Sun, Jul 16, 2023 at 9:30 PM August Wikerfors <[email protected]> wrote:
>
> On 2023-06-11 13:41, Nils Kruse wrote:
> > Add a quirk for Samsung PM9B1 256G and 512G that reports duplicate ids
> > for disk.
>
> Is this the same issue with suspend as [1], [2] and [3] or is it a
> different case?
>
> [1] https://lore.kernel.org/all/[email protected]/t/
> [2] https://github.com/tomsom/yoga-linux/issues/9
> [3] https://lore.kernel.org/all/[email protected]/

Yes, this is the same issue.