2023-07-06 12:46:10

by David Wronek

Subject: [PATCH v2 6/7] arm64: dts: qcom: Add SM7125 device tree

The Snapdragon 720G (sm7125) is software-wise very similar to the
Snapdragon 7c with minor differences in clock speeds and as added here,
it uses the Kryo 465 instead of Kryo 468.

Signed-off-by: David Wronek <[email protected]>
---
arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi

diff --git a/arch/arm64/boot/dts/qcom/sm7125.dtsi b/arch/arm64/boot/dts/qcom/sm7125.dtsi
new file mode 100644
index 000000000000..12dd72859a43
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm7125.dtsi
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ */
+
+#include "sc7180.dtsi"
+
+/* SM7125 uses Kryo 465 instead of Kryo 468 */
+&CPU0 { compatible = "qcom,kryo465"; };
+&CPU1 { compatible = "qcom,kryo465"; };
+&CPU2 { compatible = "qcom,kryo465"; };
+&CPU3 { compatible = "qcom,kryo465"; };
+&CPU4 { compatible = "qcom,kryo465"; };
+&CPU5 { compatible = "qcom,kryo465"; };
+&CPU6 { compatible = "qcom,kryo465"; };
+&CPU7 { compatible = "qcom,kryo465"; };
--
2.41.0

2023-07-06 15:38:57

by Konrad Dybcio

Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add SM7125 device tree

On 6.07.2023 14:40, David Wronek wrote:
> The Snapdragon 720G (sm7125) is software-wise very similar to the
> Snapdragon 7c with minor differences in clock speeds and as added here,
> it uses the Kryo 465 instead of Kryo 468.
>
> Signed-off-by: David Wronek <[email protected]>
> ---
Can you please paste the output of `dmesg | grep "secondary processor"`?

That would let us determine the unique identifier of the cores.

Konrad
> arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7125.dtsi b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> new file mode 100644
> index 000000000000..12dd72859a43
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + */
> +
> +#include "sc7180.dtsi"
> +
> +/* SM7125 uses Kryo 465 instead of Kryo 468 */
> +&CPU0 { compatible = "qcom,kryo465"; };
> +&CPU1 { compatible = "qcom,kryo465"; };
> +&CPU2 { compatible = "qcom,kryo465"; };
> +&CPU3 { compatible = "qcom,kryo465"; };
> +&CPU4 { compatible = "qcom,kryo465"; };
> +&CPU5 { compatible = "qcom,kryo465"; };
> +&CPU6 { compatible = "qcom,kryo465"; };
> +&CPU7 { compatible = "qcom,kryo465"; };

2023-07-06 15:48:54

by David Wronek

Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add SM7125 device tree

On Thu, Jul 6, 2023 at 5:25 PM Konrad Dybcio <[email protected]> wrote:
> On 6.07.2023 14:40, David Wronek wrote:
> > The Snapdragon 720G (sm7125) is software-wise very similar to the
> > Snapdragon 7c with minor differences in clock speeds and as added here,
> > it uses the Kryo 465 instead of Kryo 468.
> >
> > Signed-off-by: David Wronek <[email protected]>
> > ---
> Can you please paste the output of `dmesg | grep "secondary processor"`?
>
> That would let us determine the unique identifier of the cores.
>
> Konrad
I get this output with the command:
[ 0.005884] CPU1: Booted secondary processor 0x0000000100 [0x51df805e]
[ 0.007191] CPU2: Booted secondary processor 0x0000000200 [0x51df805e]
[ 0.008559] CPU3: Booted secondary processor 0x0000000300 [0x51df805e]
[ 0.010046] CPU4: Booted secondary processor 0x0000000400 [0x51df805e]
[ 0.011639] CPU5: Booted secondary processor 0x0000000500 [0x51df805e]
[ 0.014424] CPU6: Booted secondary processor 0x0000000600 [0x51ff804f]
[ 0.016421] CPU7: Booted secondary processor 0x0000000700 [0x51ff804f]

Sincerely,
David
> > arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm7125.dtsi b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> > new file mode 100644
> > index 000000000000..12dd72859a43
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> > @@ -0,0 +1,16 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + */
> > +
> > +#include "sc7180.dtsi"
> > +
> > +/* SM7125 uses Kryo 465 instead of Kryo 468 */
> > +&CPU0 { compatible = "qcom,kryo465"; };
> > +&CPU1 { compatible = "qcom,kryo465"; };
> > +&CPU2 { compatible = "qcom,kryo465"; };
> > +&CPU3 { compatible = "qcom,kryo465"; };
> > +&CPU4 { compatible = "qcom,kryo465"; };
> > +&CPU5 { compatible = "qcom,kryo465"; };
> > +&CPU6 { compatible = "qcom,kryo465"; };
> > +&CPU7 { compatible = "qcom,kryo465"; };

2023-07-07 12:43:24

by Konrad Dybcio

Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add SM7125 device tree

On 6.07.2023 17:36, David Wronek wrote:
> On Thu, Jul 6, 2023 at 5:25 PM Konrad Dybcio <[email protected]> wrote:
>> On 6.07.2023 14:40, David Wronek wrote:
>>> The Snapdragon 720G (sm7125) is software-wise very similar to the
>>> Snapdragon 7c with minor differences in clock speeds and as added here,
>>> it uses the Kryo 465 instead of Kryo 468.
>>>
>>> Signed-off-by: David Wronek <[email protected]>
>>> ---
>> Can you please paste the output of `dmesg | grep "secondary processor"`?
>>
>> That would let us determine the unique identifier of the cores.
>>
>> Konrad
> I get this output with the command:
> [ 0.005884] CPU1: Booted secondary processor 0x0000000100 [0x51df805e]
> [ 0.007191] CPU2: Booted secondary processor 0x0000000200 [0x51df805e]
> [ 0.008559] CPU3: Booted secondary processor 0x0000000300 [0x51df805e]
> [ 0.010046] CPU4: Booted secondary processor 0x0000000400 [0x51df805e]
> [ 0.011639] CPU5: Booted secondary processor 0x0000000500 [0x51df805e]
> [ 0.014424] CPU6: Booted secondary processor 0x0000000600 [0x51ff804f]
> [ 0.016421] CPU7: Booted secondary processor 0x0000000700 [0x51ff804f]
Hm okay so they are indeed Qualcomm-branded cores.. Sometimes they use the
ARM ones and still call it Kryo

btw the implementer id of 0x51 is the ascii code of 'Q', nice quirk

Konrad
>
> Sincerely,
> David
>>> arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm7125.dtsi b/arch/arm64/boot/dts/qcom/sm7125.dtsi
>>> new file mode 100644
>>> index 000000000000..12dd72859a43
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/sm7125.dtsi
>>> @@ -0,0 +1,16 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
>>> + */
>>> +
>>> +#include "sc7180.dtsi"
>>> +
>>> +/* SM7125 uses Kryo 465 instead of Kryo 468 */
>>> +&CPU0 { compatible = "qcom,kryo465"; };
>>> +&CPU1 { compatible = "qcom,kryo465"; };
>>> +&CPU2 { compatible = "qcom,kryo465"; };
>>> +&CPU3 { compatible = "qcom,kryo465"; };
>>> +&CPU4 { compatible = "qcom,kryo465"; };
>>> +&CPU5 { compatible = "qcom,kryo465"; };
>>> +&CPU6 { compatible = "qcom,kryo465"; };
>>> +&CPU7 { compatible = "qcom,kryo465"; };