2021-04-19 06:05:49

by Sebastian Fricke

Subject: [PATCH] media: rkisp1: rkisp1-params.c: Fix typos

s/when the camera active/when the camera is active/
s/thus not isr protection/thus no ISR protection/

Signed-off-by: Sebastian Fricke <[email protected]>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
index b6beddd988d0..ead948a2d01e 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
@@ -1258,7 +1258,7 @@ void rkisp1_params_configure(struct rkisp1_params *params,
rkisp1_params_config_parameter(params);
}

-/* Not called when the camera active, thus not isr protection. */
+/* Not called when the camera is active, thus no ISR protection. */
void rkisp1_params_disable(struct rkisp1_params *params)
{
rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPCC_MODE,
--
2.25.1

2021-04-20 09:27:18

by Dafna Hirschfeld

Subject: Re: [PATCH] media: rkisp1: rkisp1-params.c: Fix typos

Hi,


On 19.04.21 08:02, Sebastian Fricke wrote:
> s/when the camera active/when the camera is active/
> s/thus not isr protection/thus no ISR protection/
>
> Signed-off-by: Sebastian Fricke <[email protected]>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> index b6beddd988d0..ead948a2d01e 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> @@ -1258,7 +1258,7 @@ void rkisp1_params_configure(struct rkisp1_params *params,
> rkisp1_params_config_parameter(params);
> }
>
> -/* Not called when the camera active, thus not isr protection. */
> +/* Not called when the camera is active, thus no ISR protection. */

I think it would better to write

/* Not called when the camera is active, therefore there is no need to acquire a lock */

Thanks,
Dafna

> void rkisp1_params_disable(struct rkisp1_params *params)
> {
> rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPCC_MODE,
>