2021-02-02 06:30:03

by Yang Li

Subject: [PATCH] firmware: ti_sci: rm: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/firmware/ti_sci.c:1762:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/firmware/ti_sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 235c7e7..5ae2040 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
desc->num = resp->range_num;
desc->start_sec = resp->range_start_sec;
desc->num_sec = resp->range_num_sec;
- };
+ }

fail:
ti_sci_put_one_xfer(&info->minfo, xfer);
--
1.8.3.1

2021-02-02 23:53:20

by Nishanth Menon

Subject: Re: [PATCH] firmware: ti_sci: rm: remove unneeded semicolon

On 14:23-20210202, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/firmware/ti_sci.c:1762:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/firmware/ti_sci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 235c7e7..5ae2040 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
> desc->num = resp->range_num;
> desc->start_sec = resp->range_start_sec;
> desc->num_sec = resp->range_num_sec;
> - };
> + }
>


Uggh.. thanks..

Reviewed-by: Nishanth Menon <[email protected]>


Santosh: I know you have send your Soc fixes for merge, but will be
great if you could pick for a future version, this is minor enough not
to bother the stable, I think..


--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2021-02-03 00:33:21

by Santosh Shilimkar

Subject: Re: [External] : Re: [PATCH] firmware: ti_sci: rm: remove unneeded semicolon

On Feb 2, 2021, at 9:17 AM, Nishanth Menon <[email protected]> wrote:
>
> On 14:23-20210202, Yang Li wrote:
>> Eliminate the following coccicheck warning:
>> ./drivers/firmware/ti_sci.c:1762:2-3: Unneeded semicolon
>>
>> Reported-by: Abaci Robot <[email protected]>
>> Signed-off-by: Yang Li <[email protected]>
>> ---
>> drivers/firmware/ti_sci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
>> index 235c7e7..5ae2040 100644
>> --- a/drivers/firmware/ti_sci.c
>> +++ b/drivers/firmware/ti_sci.c
>> @@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
>> desc->num = resp->range_num;
>> desc->start_sec = resp->range_start_sec;
>> desc->num_sec = resp->range_num_sec;
>> - };
>> + }
>>
>
>
> Uggh.. thanks..
>
> Reviewed-by: Nishanth Menon <[email protected]>
>
>
> Santosh: I know you have send your Soc fixes for merge, but will be
> great if you could pick for a future version, this is minor enough not
> to bother the stable, I think..

Yes, this can wait for next one.

Regards,
Santosh