Remove 'IRQF_TRIGGER_FALLING' request which is not allowed on
every interrupt controller (i.e. arm64 GIC). Replace flag by a
request that depends on the actual device-tree setting.
Reported-by: kernel test robot <[email protected]>
Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Lukas Funke <[email protected]>
Signed-off-by: Chanwoo Choi <[email protected]>
---
Changes from v2
- Use IRQF_TRIGGER_FALLING if there are no irq_data on devicetree
drivers/extcon/extcon-usbc-tusb320.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-usbc-tusb320.c
b/drivers/extcon/extcon-usbc-tusb320.c
index 4d08c2123e59..2eab341de6b7 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -17,6 +17,7 @@
#include <linux/usb/typec.h>
#include <linux/usb/typec_altmode.h>
#include <linux/usb/role.h>
+#include <linux/irq.h>
#define TUSB320_REG8 0x8
#define TUSB320_REG8_CURRENT_MODE_ADVERTISE GENMASK(7, 6)
@@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client *client)
const void *match_data;
unsigned int revision;
int ret;
+ u32 irq_trigger_type = IRQF_TRIGGER_FALLING;
+ struct irq_data *irq_d;
priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -568,9 +571,13 @@ static int tusb320_probe(struct i2c_client *client)
*/
tusb320_state_update_handler(priv, true);
+ irq_d = irq_get_irq_data(client->irq);
+ if (irq_d)
+ irq_trigger_type = irqd_get_trigger_type(irq_d);
+
ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
tusb320_irq_handler,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_ONESHOT | irq_trigger_type,
client->name, priv);
if (ret)
tusb320_typec_remove(priv);
--
2.25.1
> -----Original Message-----
> From: Chanwoo Choi <[email protected]>
> Sent: Tuesday, December 5, 2023 10:07 AM
> To: [email protected]
> Cc: 'Lukas Funke' <[email protected]>; 'Signed-off-by:
> Chanwoo Choi' <[email protected]>; 'Chanwoo Choi' <[email protected]>;
> 'MyungJoo Ham' <[email protected]>; 'Reported-by: kernel test robot'
> <[email protected]>
> Subject: [PATCH v3] extcon: usbc-tusb320: Set interrupt polarity based on
> device-tree
>
> Remove 'IRQF_TRIGGER_FALLING' request which is not allowed on every
> interrupt controller (i.e. arm64 GIC). Replace flag by a request that
> depends on the actual device-tree setting.
>
> Reported-by: kernel test robot <[email protected]>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Lukas Funke <[email protected]>
> Signed-off-by: Chanwoo Choi <[email protected]>
> ---
> Changes from v2
> - Use IRQF_TRIGGER_FALLING if there are no irq_data on devicetree
>
> drivers/extcon/extcon-usbc-tusb320.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-usbc-tusb320.c
> b/drivers/extcon/extcon-usbc-tusb320.c
> index 4d08c2123e59..2eab341de6b7 100644
> --- a/drivers/extcon/extcon-usbc-tusb320.c
> +++ b/drivers/extcon/extcon-usbc-tusb320.c
> @@ -17,6 +17,7 @@
> #include <linux/usb/typec.h>
> #include <linux/usb/typec_altmode.h>
> #include <linux/usb/role.h>
> +#include <linux/irq.h>
>
> #define TUSB320_REG8 0x8
> #define TUSB320_REG8_CURRENT_MODE_ADVERTISE GENMASK(7, 6)
> @@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client *client)
> const void *match_data;
> unsigned int revision;
> int ret;
> + u32 irq_trigger_type = IRQF_TRIGGER_FALLING;
> + struct irq_data *irq_d;
>
> priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> @@ -568,9 +571,13 @@ static int tusb320_probe(struct i2c_client *client)
> */
> tusb320_state_update_handler(priv, true);
>
> + irq_d = irq_get_irq_data(client->irq);
> + if (irq_d)
> + irq_trigger_type = irqd_get_trigger_type(irq_d);
> +
> ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
> tusb320_irq_handler,
> - IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + IRQF_ONESHOT | irq_trigger_type,
> client->name, priv);
> if (ret)
> tusb320_typec_remove(priv);
> --
> 2.25.1
Applied it. Thanks.
Best Regards,
Chanwoo Choi