2013-09-24 15:59:43

by Mateusz Krawczuk

Subject: [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init

It prevents from executing things already handled by pinctrl-exynos driver,
when device tree is available.

Signed-off-by: Mateusz Krawczuk <[email protected]>
Signed-off-by: Kyungmin Park <[email protected]>
---
arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/plat-samsung/s5p-irq-eint.c b/arch/arm/plat-samsung/s5p-irq-eint.c
index faa6516..ebee4dc 100644
--- a/arch/arm/plat-samsung/s5p-irq-eint.c
+++ b/arch/arm/plat-samsung/s5p-irq-eint.c
@@ -16,6 +16,7 @@
#include <linux/device.h>
#include <linux/gpio.h>
#include <linux/irqchip/arm-vic.h>
+#include <linux/of.h>

#include <plat/regs-irqtype.h>

@@ -202,6 +203,9 @@ static int __init s5p_init_irq_eint(void)
{
int irq;

+ if (of_have_populated_dt())
+ return -ENODEV;
+
for (irq = IRQ_EINT(0); irq <= IRQ_EINT(15); irq++)
irq_set_chip(irq, &s5p_irq_vic_eint);

--
1.8.1.2

2013-09-24 19:19:46

by Tomasz Figa

Subject: Re: [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init

Hi Mateusz,

On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote:
> It prevents from executing things already handled by pinctrl-exynos
> driver, when device tree is available.
>
> Signed-off-by: Mateusz Krawczuk <[email protected]>
> Signed-off-by: Kyungmin Park <[email protected]>
> ---
> arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> 1 file changed, 4 insertions(+)

Acked-by: Tomasz Figa <[email protected]>

[as a temporary solution until we move all the users of this code to
device tree]

Best regards,
Tomasz

2013-09-26 05:29:19

by Kukjin Kim

Subject: RE: [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init

Tomasz Figa wrote:
>
> Hi Mateusz,
>
> On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote:
> > It prevents from executing things already handled by pinctrl-exynos
> > driver, when device tree is available.
> >
> > Signed-off-by: Mateusz Krawczuk <[email protected]>
> > Signed-off-by: Kyungmin Park <[email protected]>
> > ---
> > arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Acked-by: Tomasz Figa <[email protected]>
>
> [as a temporary solution until we move all the users of this code to
> device tree]
>
Yes, agreed.

The 'skip irq init' in subject would be changed to 'skip eint init' for
clear meaning.

Applied.

Thanks,
Kukjin