2022-07-06 09:53:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: cleanup assigned clocks

"assigned-clocks" are not needed in the schema as they come from DT
schema.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 3 ---
1 file changed, 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index c30a6437030d..a5d489acfdca 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -49,9 +49,6 @@ properties:
reg:
maxItems: 1

- assigned-clock-parents: true
- assigned-clocks: true
-
'#clock-cells':
const: 1

--
2.34.1


2022-07-06 09:53:45

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/3] dt-bindings: soc: samsung: exynos-pmu: use abolute ref paths

Preferred coding for referencing other schemas is to use absolute path.
Quotes over path are also not needed.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index a5d489acfdca..1835ca08416d 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -75,13 +75,13 @@ properties:
const: 3

syscon-poweroff:
- $ref: "../../power/reset/syscon-poweroff.yaml#"
+ $ref: /schemas/power/reset/syscon-poweroff.yaml#
type: object
description:
Node for power off method

syscon-reboot:
- $ref: "../../power/reset/syscon-reboot.yaml#"
+ $ref: /schemas/power/reset/syscon-reboot.yaml#
type: object
description:
Node for reboot method
--
2.34.1

2022-07-06 10:12:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/3] dt-bindings: soc: samsung: exynos-pmu: add reboot-mode

ExynosAutov9 gained a reboot-mode node, so document the property to fix
warning:

exynosautov9-sadk.dtb: system-controller@10460000: 'reboot-mode' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/soc/samsung/exynos-pmu.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index 1835ca08416d..13bb8dfcefe6 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -74,6 +74,12 @@ properties:
Must be identical to the that of the parent interrupt controller.
const: 3

+ reboot-mode:
+ $ref: /schemas/power/reset/syscon-reboot-mode.yaml
+ type: object
+ description:
+ Reboot mode to alter bootloader behavior for the next boot
+
syscon-poweroff:
$ref: /schemas/power/reset/syscon-poweroff.yaml#
type: object
--
2.34.1

2022-07-06 11:42:23

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 3/3] dt-bindings: soc: samsung: exynos-pmu: add reboot-mode



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Wednesday, July 6, 2022 3:21 PM
>To: Rob Herring <[email protected]>; Krzysztof Kozlowski
><[email protected]>; Alim Akhtar <[email protected]>;
>[email protected]; [email protected]; linux-
>[email protected]; [email protected]
>Cc: Chanho Park <[email protected]>; Krzysztof Kozlowski
><[email protected]>
>Subject: [PATCH 3/3] dt-bindings: soc: samsung: exynos-pmu: add reboot-mode
>
>ExynosAutov9 gained a reboot-mode node, so document the property to fix
>warning:
>
> exynosautov9-sadk.dtb: system-controller@10460000: 'reboot-mode' does not
>match any of the regexes: 'pinctrl-[0-9]+'
>
>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>---

Reviewed-by: Alim Akhtar <[email protected]>

> .../devicetree/bindings/soc/samsung/exynos-pmu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>index 1835ca08416d..13bb8dfcefe6 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>@@ -74,6 +74,12 @@ properties:
> Must be identical to the that of the parent interrupt controller.
> const: 3
>
>+ reboot-mode:
>+ $ref: /schemas/power/reset/syscon-reboot-mode.yaml
>+ type: object
>+ description:
>+ Reboot mode to alter bootloader behavior for the next boot
>+
> syscon-poweroff:
> $ref: /schemas/power/reset/syscon-poweroff.yaml#
> type: object
>--
>2.34.1


2022-07-06 11:58:47

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: cleanup assigned clocks



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Wednesday, July 6, 2022 3:21 PM
>To: Rob Herring <[email protected]>; Krzysztof Kozlowski
><[email protected]>; Alim Akhtar <[email protected]>;
>[email protected]; [email protected]; linux-
>[email protected]; [email protected]
>Cc: Chanho Park <[email protected]>; Krzysztof Kozlowski
><[email protected]>
>Subject: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: cleanup
assigned
>clocks
>
>"assigned-clocks" are not needed in the schema as they come from DT schema.
>
Sorry, I didn't get this, you mean "assigned-clocks" comes from DT so it is
not required to be mentioned in schema?

>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>---
> Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>index c30a6437030d..a5d489acfdca 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>@@ -49,9 +49,6 @@ properties:
> reg:
> maxItems: 1
>
>- assigned-clock-parents: true
>- assigned-clocks: true
>-
> '#clock-cells':
> const: 1
>
>--
>2.34.1


2022-07-06 12:03:41

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 2/3] dt-bindings: soc: samsung: exynos-pmu: use abolute ref paths



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Wednesday, July 6, 2022 3:21 PM
>To: Rob Herring <[email protected]>; Krzysztof Kozlowski
><[email protected]>; Alim Akhtar <[email protected]>;
>[email protected]; [email protected]; linux-
>[email protected]; [email protected]
>Cc: Chanho Park <[email protected]>; Krzysztof Kozlowski
><[email protected]>
>Subject: [PATCH 2/3] dt-bindings: soc: samsung: exynos-pmu: use abolute ref
>paths
>
>Preferred coding for referencing other schemas is to use absolute path.
>Quotes over path are also not needed.
>
>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>---

Reviewed-by: Alim Akhtar <[email protected]>

> Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>index a5d489acfdca..1835ca08416d 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>@@ -75,13 +75,13 @@ properties:
> const: 3
>
> syscon-poweroff:
>- $ref: "../../power/reset/syscon-poweroff.yaml#"
>+ $ref: /schemas/power/reset/syscon-poweroff.yaml#
> type: object
> description:
> Node for power off method
>
> syscon-reboot:
>- $ref: "../../power/reset/syscon-reboot.yaml#"
>+ $ref: /schemas/power/reset/syscon-reboot.yaml#
> type: object
> description:
> Node for reboot method
>--
>2.34.1


2022-07-06 15:10:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: cleanup assigned clocks

On 06/07/2022 13:21, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:[email protected]]
>> Sent: Wednesday, July 6, 2022 3:21 PM
>> To: Rob Herring <[email protected]>; Krzysztof Kozlowski
>> <[email protected]>; Alim Akhtar <[email protected]>;
>> [email protected]; [email protected]; linux-
>> [email protected]; [email protected]
>> Cc: Chanho Park <[email protected]>; Krzysztof Kozlowski
>> <[email protected]>
>> Subject: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: cleanup
> assigned
>> clocks
>>
>> "assigned-clocks" are not needed in the schema as they come from DT schema.
>>
> Sorry, I didn't get this, you mean "assigned-clocks" comes from DT so it is
> not required to be mentioned in schema?

Maybe this is not accurate, so I can rephrase it to:

"assigned-clocks" are not needed in the schema as they come from core
schema.

Best regards,
Krzysztof

2022-07-06 16:22:06

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: cleanup assigned clocks

On Wed, 06 Jul 2022 11:50:35 +0200, Krzysztof Kozlowski wrote:
> "assigned-clocks" are not needed in the schema as they come from DT
> schema.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2022-07-06 16:27:33

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 3/3] dt-bindings: soc: samsung: exynos-pmu: add reboot-mode

On Wed, 06 Jul 2022 11:50:37 +0200, Krzysztof Kozlowski wrote:
> ExynosAutov9 gained a reboot-mode node, so document the property to fix
> warning:
>
> exynosautov9-sadk.dtb: system-controller@10460000: 'reboot-mode' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/soc/samsung/exynos-pmu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2022-07-06 16:36:52

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: soc: samsung: exynos-pmu: use abolute ref paths

On Wed, 06 Jul 2022 11:50:36 +0200, Krzysztof Kozlowski wrote:
> Preferred coding for referencing other schemas is to use absolute path.
> Quotes over path are also not needed.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>