From: Longfang Liu <[email protected]>
1.Add two debugfs document description file to help users understand
how to use the accelerator live migration driver's debugfs.
2.Update the file paths that need to be maintained in MAINTAINERS
Signed-off-by: Longfang Liu <[email protected]>
---
.../ABI/testing/debugfs-hisi-migration | 36 +++++++++++++++++++
Documentation/ABI/testing/debugfs-vfio | 25 +++++++++++++
MAINTAINERS | 2 ++
3 files changed, 63 insertions(+)
create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration
create mode 100644 Documentation/ABI/testing/debugfs-vfio
diff --git a/Documentation/ABI/testing/debugfs-hisi-migration b/Documentation/ABI/testing/debugfs-hisi-migration
new file mode 100644
index 000000000000..791dd8a09575
--- /dev/null
+++ b/Documentation/ABI/testing/debugfs-hisi-migration
@@ -0,0 +1,36 @@
+What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/data
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: Read the live migration data of the vfio device.
+ These data include device status data, queue configuration
+ data and some task configuration data.
+ The output format of the data is defined by the live
+ migration driver.
+
+What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/attr
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: Read the live migration attributes of the vfio device.
+ it include device status attributes and data length attributes
+ The output format of the attributes is defined by the live
+ migration driver.
+
+What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/io_test
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: Trigger the HiSilicon accelerator device to perform
+ the io test through the read operation. If successful,
+ it returns the execution result of mailbox. If fails,
+ it returns error log result.
+
+What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/save
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: Trigger the Hisilicon accelerator device to perform
+ the state saving operation of live migration through the read
+ operation, and output the operation log results.
+
diff --git a/Documentation/ABI/testing/debugfs-vfio b/Documentation/ABI/testing/debugfs-vfio
new file mode 100644
index 000000000000..086a8c52df35
--- /dev/null
+++ b/Documentation/ABI/testing/debugfs-vfio
@@ -0,0 +1,25 @@
+What: /sys/kernel/debug/vfio
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: This debugfs file directory is used for debugging
+ of vfio devices, it's a common directory for all vfio devices.
+ Each device should create a device subdirectory under this
+ directory by referencing the public registration interface.
+
+What: /sys/kernel/debug/vfio/<device>/migration
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: This debugfs file directory is used for debugging
+ of vfio devices that support live migration.
+ The debugfs of each vfio device that supports live migration
+ could be created under this directory.
+
+What: /sys/kernel/debug/vfio/<device>/migration/state
+Date: Aug 2023
+KernelVersion: 6.6
+Contact: Longfang Liu <[email protected]>
+Description: Read the live migration status of the vfio device.
+ The status of these live migrations includes:
+ ERROR, RUNNING, STOP, STOP_COPY, RESUMING.
diff --git a/MAINTAINERS b/MAINTAINERS
index d516295978a4..d4fb7547b687 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22304,6 +22304,7 @@ L: [email protected]
S: Maintained
T: git https://github.com/awilliam/linux-vfio.git
F: Documentation/ABI/testing/sysfs-devices-vfio-dev
+F: Documentation/ABI/testing/debugfs-vfio
F: Documentation/driver-api/vfio.rst
F: drivers/vfio/
F: include/linux/vfio.h
@@ -22321,6 +22322,7 @@ M: Longfang Liu <[email protected]>
M: Shameer Kolothum <[email protected]>
L: [email protected]
S: Maintained
+F: Documentation/ABI/testing/debugfs-hisi-migration
F: drivers/vfio/pci/hisilicon/
VFIO MEDIATED DEVICE DRIVERS
--
2.24.0
On Fri, Jul 28, 2023 at 03:21:04PM +0800, liulongfang wrote:
> From: Longfang Liu <[email protected]>
>
> 1.Add two debugfs document description file to help users understand
> how to use the accelerator live migration driver's debugfs.
> 2.Update the file paths that need to be maintained in MAINTAINERS
>
> Signed-off-by: Longfang Liu <[email protected]>
> ---
> .../ABI/testing/debugfs-hisi-migration | 36 +++++++++++++++++++
> Documentation/ABI/testing/debugfs-vfio | 25 +++++++++++++
> MAINTAINERS | 2 ++
> 3 files changed, 63 insertions(+)
> create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration
> create mode 100644 Documentation/ABI/testing/debugfs-vfio
>
> diff --git a/Documentation/ABI/testing/debugfs-hisi-migration b/Documentation/ABI/testing/debugfs-hisi-migration
> new file mode 100644
> index 000000000000..791dd8a09575
> --- /dev/null
> +++ b/Documentation/ABI/testing/debugfs-hisi-migration
> @@ -0,0 +1,36 @@
> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/data
> +Date: Aug 2023
> +KernelVersion: 6.6
> +Contact: Longfang Liu <[email protected]>
> +Description: Read the live migration data of the vfio device.
> + These data include device status data, queue configuration
> + data and some task configuration data.
> + The output format of the data is defined by the live
> + migration driver.
> +
> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/attr
> +Date: Aug 2023
> +KernelVersion: 6.6
> +Contact: Longfang Liu <[email protected]>
> +Description: Read the live migration attributes of the vfio device.
> + it include device status attributes and data length attributes
> + The output format of the attributes is defined by the live
> + migration driver.
> +
> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/io_test
> +Date: Aug 2023
> +KernelVersion: 6.6
> +Contact: Longfang Liu <[email protected]>
> +Description: Trigger the HiSilicon accelerator device to perform
> + the io test through the read operation. If successful,
> + it returns the execution result of mailbox. If fails,
> + it returns error log result.
> +
> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/save
> +Date: Aug 2023
> +KernelVersion: 6.6
> +Contact: Longfang Liu <[email protected]>
> +Description: Trigger the Hisilicon accelerator device to perform
> + the state saving operation of live migration through the read
> + operation, and output the operation log results.
I still very much do not like this use of debugfs.
If you want to test migration then make a test program and use the
normal api
Creating some parallel backdoor to work the same API is just
unneeded complexity.
Jason
On 2023/8/4 22:58, Jason Gunthorpe wrote:
> On Fri, Jul 28, 2023 at 03:21:04PM +0800, liulongfang wrote:
>> From: Longfang Liu <[email protected]>
>>
>> 1.Add two debugfs document description file to help users understand
>> how to use the accelerator live migration driver's debugfs.
>> 2.Update the file paths that need to be maintained in MAINTAINERS
>>
>> Signed-off-by: Longfang Liu <[email protected]>
>> ---
>> .../ABI/testing/debugfs-hisi-migration | 36 +++++++++++++++++++
>> Documentation/ABI/testing/debugfs-vfio | 25 +++++++++++++
>> MAINTAINERS | 2 ++
>> 3 files changed, 63 insertions(+)
>> create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration
>> create mode 100644 Documentation/ABI/testing/debugfs-vfio
>>
>> diff --git a/Documentation/ABI/testing/debugfs-hisi-migration b/Documentation/ABI/testing/debugfs-hisi-migration
>> new file mode 100644
>> index 000000000000..791dd8a09575
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/debugfs-hisi-migration
>> @@ -0,0 +1,36 @@
>> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/data
>> +Date: Aug 2023
>> +KernelVersion: 6.6
>> +Contact: Longfang Liu <[email protected]>
>> +Description: Read the live migration data of the vfio device.
>> + These data include device status data, queue configuration
>> + data and some task configuration data.
>> + The output format of the data is defined by the live
>> + migration driver.
>> +
>> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/attr
>> +Date: Aug 2023
>> +KernelVersion: 6.6
>> +Contact: Longfang Liu <[email protected]>
>> +Description: Read the live migration attributes of the vfio device.
>> + it include device status attributes and data length attributes
>> + The output format of the attributes is defined by the live
>> + migration driver.
>> +
>> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/io_test
>> +Date: Aug 2023
>> +KernelVersion: 6.6
>> +Contact: Longfang Liu <[email protected]>
>> +Description: Trigger the HiSilicon accelerator device to perform
>> + the io test through the read operation. If successful,
>> + it returns the execution result of mailbox. If fails,
>> + it returns error log result.
>> +
>> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/save
>> +Date: Aug 2023
>> +KernelVersion: 6.6
>> +Contact: Longfang Liu <[email protected]>
>> +Description: Trigger the Hisilicon accelerator device to perform
>> + the state saving operation of live migration through the read
>> + operation, and output the operation log results.
>
> I still very much do not like this use of debugfs.
>
> If you want to test migration then make a test program and use the
> normal api
>
These debugfs are just to get internal state data.
The test function is no longer executed.
The store file with test function has been deleted.
Thanks,
Longfang.
> Creating some parallel backdoor to work the same API is just
> unneeded complexity.
>
> Jason
> .
>
On Mon, 7 Aug 2023 09:33:07 +0800
liulongfang <[email protected]> wrote:
> On 2023/8/4 22:58, Jason Gunthorpe wrote:
> > On Fri, Jul 28, 2023 at 03:21:04PM +0800, liulongfang wrote:
> >> From: Longfang Liu <[email protected]>
> >>
> >> 1.Add two debugfs document description file to help users understand
> >> how to use the accelerator live migration driver's debugfs.
> >> 2.Update the file paths that need to be maintained in MAINTAINERS
> >>
> >> Signed-off-by: Longfang Liu <[email protected]>
> >> ---
> >> .../ABI/testing/debugfs-hisi-migration | 36 +++++++++++++++++++
> >> Documentation/ABI/testing/debugfs-vfio | 25 +++++++++++++
> >> MAINTAINERS | 2 ++
> >> 3 files changed, 63 insertions(+)
> >> create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration
> >> create mode 100644 Documentation/ABI/testing/debugfs-vfio
> >>
> >> diff --git a/Documentation/ABI/testing/debugfs-hisi-migration b/Documentation/ABI/testing/debugfs-hisi-migration
> >> new file mode 100644
> >> index 000000000000..791dd8a09575
> >> --- /dev/null
> >> +++ b/Documentation/ABI/testing/debugfs-hisi-migration
> >> @@ -0,0 +1,36 @@
> >> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/data
> >> +Date: Aug 2023
> >> +KernelVersion: 6.6
> >> +Contact: Longfang Liu <[email protected]>
> >> +Description: Read the live migration data of the vfio device.
> >> + These data include device status data, queue configuration
> >> + data and some task configuration data.
> >> + The output format of the data is defined by the live
> >> + migration driver.
> >> +
> >> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/attr
> >> +Date: Aug 2023
> >> +KernelVersion: 6.6
> >> +Contact: Longfang Liu <[email protected]>
> >> +Description: Read the live migration attributes of the vfio device.
> >> + it include device status attributes and data length attributes
> >> + The output format of the attributes is defined by the live
> >> + migration driver.
> >> +
> >> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/io_test
> >> +Date: Aug 2023
> >> +KernelVersion: 6.6
> >> +Contact: Longfang Liu <[email protected]>
> >> +Description: Trigger the HiSilicon accelerator device to perform
> >> + the io test through the read operation. If successful,
> >> + it returns the execution result of mailbox. If fails,
> >> + it returns error log result.
> >> +
> >> +What: /sys/kernel/debug/vfio/<device>/migration/hisi_acc/save
> >> +Date: Aug 2023
> >> +KernelVersion: 6.6
> >> +Contact: Longfang Liu <[email protected]>
> >> +Description: Trigger the Hisilicon accelerator device to perform
> >> + the state saving operation of live migration through the read
> >> + operation, and output the operation log results.
> >
> > I still very much do not like this use of debugfs.
> >
> > If you want to test migration then make a test program and use the
> > normal api
> >
> These debugfs are just to get internal state data.
> The test function is no longer executed.
> The store file with test function has been deleted.
The vfio/<device>/migration/state file can provide useful monitoring of
the device progress during a migration, but I think the point Jason is
trying to make is that these hisi_acc seqfiles aren't really doing
anything that couldn't be done by a simple userspace test driver.
Based on my review of the previous patch, we're playing pretty loose
with concurrency and data buffers. Access to the migration data of
the device outside of the process that owns the device is also a
concern.
The value-add here needs to be that there's something useful about the
kernel being able to dump this data rather than either a simple
userspace program or instrumenting a userspace driver like QEMU, where
we can avoid the complexity that's going to be required to resolve the
issues in the previous patch and ensure that sensitive data from the
device isn't available through debugfs. Thanks,
Alex
On 2023/8/8 6:03, Alex Williamson wrote:
> The vfio/<device>/migration/state file can provide useful monitoring of
> the device progress during a migration, but I think the point Jason is
> trying to make is that these hisi_acc seqfiles aren't really doing
> anything that couldn't be done by a simple userspace test driver.
>The state file was originally used to provide a migration state.
When the migration fails, it is used to locate the problem.
For it, we have no other functional demands.
> Based on my review of the previous patch, we're playing pretty loose
> with concurrency and data buffers. Access to the migration data of
> the device outside of the process that owns the device is also a
> concern.
>
> The value-add here needs to be that there's something useful about the
> kernel being able to dump this data rather than either a simple
> userspace program or instrumenting a userspace driver like QEMU, where
> we can avoid the complexity that's going to be required to resolve the
> issues in the previous patch and ensure that sensitive data from the
> device isn't available through debugfs.
The question of whether the migrated data is sensitive data.
It is up to the device driver to choose which data can be output.
Currently, the data that can be output through debugfs in this
HiSilicon device driver does not involve sensitive data.
Thanks,
Longfang.