2023-09-12 18:28:57

by Mario Limonciello

[permalink] [raw]
Subject: Re: [PATCH 3/3] pinctrl: amd: Add a quirk for Lenovo Ideapad 5

On 9/12/2023 03:58, Hans de Goede wrote:
> Hi,
>
> On 9/12/23 09:08, Linus Walleij wrote:
>> On Thu, Aug 31, 2023 at 7:53 PM Mario Limonciello
>> <[email protected]> wrote:
>>
>>> Linus - please disregard version 1.
>>
>> OK!
>>
>>> I provided Luca a new series that implements this approach that Hans and
>>> I discussed and they confirmed it works.
>>>
>>> I have some minor modifications to it to narrow where it's applied so we
>>> don't have needless notifications and will send it for review after the
>>> new modifications are tested as well.
>>
>> OK standing by, I'll wait for Hans' ACK and then merge it for fixes.
>
> AFAICT Mario has not posted a new version (yet),
> so there is nothing for me to ack (yet).
>
> Regards,
>
> Hans
>
>

Yeah it looked like we were about to have a new version to post last
week but there are some inconsistent results that we need to understand
still, especially with comparing to Windows.


2023-09-14 02:26:27

by Mario Limonciello

[permalink] [raw]
Subject: Re: [PATCH 3/3] pinctrl: amd: Add a quirk for Lenovo Ideapad 5

On 9/12/2023 13:21, Mario Limonciello wrote:
> On 9/12/2023 03:58, Hans de Goede wrote:
>> Hi,
>>
>> On 9/12/23 09:08, Linus Walleij wrote:
>>> On Thu, Aug 31, 2023 at 7:53 PM Mario Limonciello
>>> <[email protected]> wrote:
>>>
>>>> Linus - please disregard version 1.
>>>
>>> OK!
>>>
>>>> I provided Luca a new series that implements this approach that Hans
>>>> and
>>>> I discussed and they confirmed it works.
>>>>
>>>> I have some minor modifications to it to narrow where it's applied
>>>> so we
>>>> don't have needless notifications and will send it for review after the
>>>> new modifications are tested as well.
>>>
>>> OK standing by, I'll wait for Hans' ACK and then merge it for fixes.
>>
>> AFAICT Mario has not posted a new version (yet),
>> so there is nothing for me to ack (yet).
>>
>> Regards,
>>
>> Hans
>>
>>
>
> Yeah it looked like we were about to have a new version to post last
> week but there are some inconsistent results that we need to understand
> still, especially with comparing to Windows.

I've got two pieces of news to share on this issue.

1. In further testing Luca confirmed that the issue was behaving
identically in Windows. We were bug compliant.

2. In better news updating the BIOS fixed the issue in both Linux and
Windows, no kernel patches needed.

So no further work will be done on this series.

2023-09-14 09:23:23

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 3/3] pinctrl: amd: Add a quirk for Lenovo Ideapad 5

On Wed, Sep 13, 2023 at 11:21 PM Mario Limonciello
<[email protected]> wrote:

> 2. In better news updating the BIOS fixed the issue in both Linux and
> Windows, no kernel patches needed.
>
> So no further work will be done on this series.

Is it easy for users to update BIOS? I.e. does
fwupdmgr update work?

Or does it require flashing special USB drives with FAT filesystems...?

Because I'm not sure all users will do that. Or even be aware that
they should. In that case detecting the situation and emitting
a dev_err() telling the user to update their BIOS would be
desirable I think?

Yours,
Linus Walleij

2023-09-14 10:54:07

by Luca Pigliacampo

[permalink] [raw]
Subject: Re: [PATCH 3/3] pinctrl: amd: Add a quirk for Lenovo Ideapad 5

On 9/14/23 10:43, Linus Walleij wrote:

> On Wed, Sep 13, 2023 at 11:21 PM Mario Limonciello
> <[email protected]> wrote:
>
>> 2. In better news updating the BIOS fixed the issue in both Linux and
>> Windows, no kernel patches needed.
>>
>> So no further work will be done on this series.
> Is it easy for users to update BIOS? I.e. does
> fwupdmgr update work?
>
> Or does it require flashing special USB drives with FAT filesystems...?
>
> Because I'm not sure all users will do that. Or even be aware that
> they should. In that case detecting the situation and emitting
> a dev_err() telling the user to update their BIOS would be
> desirable I think?
>
> Yours,
> Linus Walleij

sadly it's not convenient,

the only way lenovo offers to update the bios

is an executable to run on windows.


So a user should either have a dual boot

or install windows on an external drive and boot from that,

also the update process might wipe every boot entry beside windows.


I read that some bios updaters also run on freedos, but i didn't try

2023-09-15 01:46:32

by Mario Limonciello

[permalink] [raw]
Subject: Re: [PATCH 3/3] pinctrl: amd: Add a quirk for Lenovo Ideapad 5

On 9/14/2023 04:08, Luca Pigliacampo wrote:
> On 9/14/23 10:43, Linus Walleij wrote:
>
>> On Wed, Sep 13, 2023 at 11:21 PM Mario Limonciello
>> <[email protected]> wrote:
>>
>>> 2. In better news updating the BIOS fixed the issue in both Linux and
>>> Windows, no kernel patches needed.
>>>
>>> So no further work will be done on this series.
>> Is it easy for users to update BIOS? I.e. does
>> fwupdmgr update work?
>>
>> Or does it require flashing special USB drives with FAT filesystems...?
>>
>> Because I'm not sure all users will do that. Or even be aware that
>> they should. In that case detecting the situation and emitting
>> a dev_err() telling the user to update their BIOS would be
>> desirable I think?
>>

I'm not sure how to detect it without giving false positives to users
with no problems.

>> Yours,
>> Linus Walleij
>
> sadly it's not convenient,
>
> the only way lenovo offers to update the bios
>
> is an executable to run on windows.
>
>
> So a user should either have a dual boot
>
> or install windows on an external drive and boot from that,
>
> also the update process might wipe every boot entry beside windows.
>
>
> I read that some bios updaters also run on freedos, but i didn't try
>

On some systems Lenovo offers native updates for Linux, but I guess not
this one.