2022-05-27 09:14:31

by Miaoqian Lin

[permalink] [raw]
Subject: Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init


On 2022/5/26 21:17, Marc Zyngier wrote:
> On Thu, 26 May 2022 08:43:48 +0100,
> Miaoqian Lin <[email protected]> wrote:
>> of_find_matching_node_and_match() returns a node pointer with refcount
>> incremented, we should use of_node_put() on it when not need anymore.
>> Add missing of_node_put() to avoid refcount leak.
>>
>> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
>> Signed-off-by: Miaoqian Lin <[email protected]>
> Instead of sending these one after the other, why don't you send a
> series addressing the irqchip drivers in one go? That'd be much easier
> to manage and review.

Hi, Marc

Thanks for your suggestion, I will do that.

> Thanks,
>
> M.
>