On 4/24/24 4:16 AM, Wren Turkal wrote:
> On 4/24/24 2:04 AM, Bartosz Golaszewski wrote:
>> On Wed, 24 Apr 2024 07:07:05 +0200, Wren Turkal<[email protected]>
>> said:
>>> On 4/22/24 6:00 AM, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski<[email protected]>
>>>>
>>>> Any return value from gpiod_get_optional() other than a pointer to a
>>>> GPIO descriptor or a NULL-pointer is an error and the driver should
>>>> abort probing. That being said: commit 56d074d26c58 ("Bluetooth:
>>>> hci_qca:
>>>> don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets
>>>> power_ctrl_enabled on NULL-pointer returned by
>>>> devm_gpiod_get_optional(). Restore this behavior but bail-out on
>>>> errors.
>>> Nack. This patch does fixes neither the disable/re-enable problem nor
>>> the warm boot problem.
>>>
>>> Zijun replied to this patch also with what I think is the proper
>>> reasoning for why it doesn't fix my setup.
>>>
>> Indeed, I only addressed a single issue here and not the code under the
>> default: label of the switch case. Sorry.
>>
>> Could you give the following diff a try?
>
> I had a feeling that was what was going on. I'll give the patch a shot.
>
> wt
Considering this patch is basically equivalent to patch 1/2 from Zijun,
I am not surprised that is works similarly. I.e. on a cold boot, I can
disable/re-enable bluetooth as many time as I want.
However, since this patch doesn't include the quirk fix from Zijun's
patchset (patch 2/2), bluetooth fails to work after a warm boot.
@Zijun, this patch looks more idiomatic when I look at the surrounding
code than your patch 1/2. Notice how it doesn't use the "else if"
construct. It does the NULL test separately after checking for errors.
--
You're more amazing than you think!