2017-11-17 18:43:25

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 1/5] dt-bindings: i2c: update documentation for the Meson-AXG

On 17/11/2017 09:02, Yixun Lan wrote:
> From: Jian Hu <[email protected]>
>
> Update the doc to explicitly add Meson-AXG to support list
>
> Signed-off-by: Jian Hu <[email protected]>
> Signed-off-by: Yixun Lan <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/i2c-meson.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> index 611b934c7e10..3097d2b44dad 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
> @@ -2,6 +2,7 @@ Amlogic Meson I2C controller
>
> Required properties:
> - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
> + "amlogic,meson-axg-i2c"

Hi Yixun, Jian,

Maybe you should reformat by using :
- compatible: must be :
"amlogic,meson6-i2c" for Meson8 and compatible SoCs
"amlogic,meson-gxbb-i2c" for GXBB and compatible SoCs
"amlogic,meson-axg-i2c"for AXG and compatible SoCs

Neil

> - reg: physical address and length of the device registers
> - interrupts: a single interrupt specifier
> - clocks: clock for the device
>


From 1584324340863007116@xxx Fri Nov 17 14:37:12 +0000 2017
X-GM-THRID: 1584324340863007116
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread