2017-12-08 17:42:59

by Stefan Brüns

Subject: [PATCH v1 1/7] iio: adc: ina2xx: Remove bogus cast for data argument

iio_push_to_buffers_with_timestamp expects a void pointer, so the cast
is both unnecessary and misleading.

Signed-off-by: Stefan Brüns <[email protected]>
---

drivers/iio/adc/ina2xx-adc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
index ddf878163bf9..3195f8754c3b 100644
--- a/drivers/iio/adc/ina2xx-adc.c
+++ b/drivers/iio/adc/ina2xx-adc.c
@@ -767,8 +767,7 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)

time_b = iio_get_time_ns(indio_dev);

- iio_push_to_buffers_with_timestamp(indio_dev,
- (unsigned int *)data, time_a);
+ iio_push_to_buffers_with_timestamp(indio_dev, data, time_a);

return (unsigned long)(time_b - time_a) / 1000;
};
--
2.15.1

2017-12-17 09:43:36

by Jonathan Cameron

Subject: Re: [PATCH v1 1/7] iio: adc: ina2xx: Remove bogus cast for data argument

On Fri, 8 Dec 2017 18:41:46 +0100
Stefan Brüns <[email protected]> wrote:

> iio_push_to_buffers_with_timestamp expects a void pointer, so the cast
> is both unnecessary and misleading.
>
> Signed-off-by: Stefan Brüns <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
>
> drivers/iio/adc/ina2xx-adc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index ddf878163bf9..3195f8754c3b 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -767,8 +767,7 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>
> time_b = iio_get_time_ns(indio_dev);
>
> - iio_push_to_buffers_with_timestamp(indio_dev,
> - (unsigned int *)data, time_a);
> + iio_push_to_buffers_with_timestamp(indio_dev, data, time_a);
>
> return (unsigned long)(time_b - time_a) / 1000;
> };