2004-03-29 15:45:34

by Matthew Dobson

[permalink] [raw]
Subject: Re: [PATCH] Simplify node/zone field in page->flags

Jesse Barnes wrote:
> On Mon, Jan 05, 2004 at 01:22:57PM -0800, Matthew Dobson wrote:
>
>>Jesse had acked the patch in an earlier itteration. The only thing
>>that's changed is some line offsets whilst porting the patch forward.
>>
>>Jesse (or anyone else?), any objections to this patch as a superset of
>>yours?
>
>
> No objections here. Of course, you'll have to rediff against the
> current tree since that stuff has been merged for awhile now. On a
> somewhat related note, Martin mentioned that he'd like to get rid of
> memblks. I'm all for that too; they just seem to get in the way.
>
> Jesse

Here's an updated version against 2.6.1-rc1. Small comment fix (there
are actually up to (MAX_NUMNODES * MAX_NR_ZONES) possible zones total,
not log2(MAX_NUMNODES * MAX_NR_ZONES) as your comment stated. That is
the number of bits necessary to index every possible zone.

After this goes in, we (I) can convert a number of places that are doing
several pointer dereferences/arithmetic and other things to determine
which node/zone a page belongs to simply calling
page_nodenum()/page_zonenum().

Cheers!

-Matt