2019-06-10 07:49:04

by Youngmin Nam

Subject: [PATCH] vsprintf: fix data type of variable in string_nocheck()

This patch fixes data type of precision with int.
The precision is declared as signed int in struct printf_spec.

Signed-off-by: Youngmin Nam <[email protected]>
---
lib/vsprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 63937044c57d..cd0cd9279b12 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -599,7 +599,7 @@ static char *string_nocheck(char *buf, char *end, const char *s,
struct printf_spec spec)
{
int len = 0;
- size_t lim = spec.precision;
+ int lim = spec.precision;

while (lim--) {
char c = *s++;
--
2.21.0

2019-06-10 08:17:36

by Sergey Senozhatsky

Subject: Re: [PATCH] vsprintf: fix data type of variable in string_nocheck()

On (06/10/19 16:47), 남영민 wrote:
> This patch fixes data type of precision with int.
> The precision is declared as signed int in struct printf_spec.
>
> Signed-off-by: Youngmin Nam <[email protected]>

Looks OK to me.

FWIW
Reviewed-by: Sergey Senozhatsky <[email protected]>

-ss

2019-06-12 08:41:35

by Petr Mladek

Subject: Re: [PATCH] vsprintf: fix data type of variable in string_nocheck()

On Mon 2019-06-10 17:16:54, Sergey Senozhatsky wrote:
> On (06/10/19 16:47), 남영민 wrote:
> > This patch fixes data type of precision with int.
> > The precision is declared as signed int in struct printf_spec.
> >
> > Signed-off-by: Youngmin Nam <[email protected]>
>
> Looks OK to me.
>
> FWIW
> Reviewed-by: Sergey Senozhatsky <[email protected]>

The patch has been committed into printk.git, branch for-5.3.

Best Regards,
Petr