2012-06-13 08:27:21

by Sangbeom Kim

[permalink] [raw]

Subject: [PATCH 2/5] regulator: Fix the s5m8767a problem of the division by null

---

If ramp_delay is 0, delay value can be divided by zero.
This patch can fix the problem.

Signed-off-by: Sangbeom Kim <[email protected]>
---
drivers/regulator/s5m8767.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index 4edf344..ce9dda2 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -451,7 +451,7 @@ static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,

desc = reg_voltage_map[reg_id];

- if (old_sel < new_sel)
+ if ((old_sel < new_sel) && s5m8767->ramp_delay)
return DIV_ROUND_UP(desc->step * (new_sel - old_sel),
s5m8767->ramp_delay * 1000);
return 0;
--
1.7.1

2012-06-13 17:44:29

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH 2/5] regulator: Fix the s5m8767a problem of the division by null

---

On Wed, Jun 13, 2012 at 05:27:16PM +0900, Sangbeom Kim wrote:
> If ramp_delay is 0, delay value can be divided by zero.
> This patch can fix the problem.

Applied, thanks.

---

Attachments:

(No filename) (172.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments