2012-06-13 08:28:25

by Sangbeom Kim

[permalink] [raw]
Subject: [PATCH 3/5] regulator: Modify ramp_delay value for s5m8767a

As s5m8767a is revisioned, ramp_delay register is changed.
5mV/uS, 10mV/uS, 25mV/uS, 50mV/uS, 100mV/uS ramp delay can be selected.

Signed-off-by: Sangbeom Kim <[email protected]>
---
drivers/regulator/s5m8767.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index ce9dda2..924968a 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -681,9 +681,13 @@ static __devinit int s5m8767_pmic_probe(struct platform_device *pdev)
if (s5m8767->buck2_ramp || s5m8767->buck3_ramp
|| s5m8767->buck4_ramp) {
switch (s5m8767->ramp_delay) {
- case 15:
+ case 5:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
- 0xc0, 0xf0);
+ 0x40, 0xf0);
+ break;
+ case 10:
+ s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
+ 0x90, 0xf0);
break;
case 25:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
--
1.7.1


2012-06-13 17:59:35

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 3/5] regulator: Modify ramp_delay value for s5m8767a

On Wed, Jun 13, 2012 at 05:27:54PM +0900, Sangbeom Kim wrote:
> As s5m8767a is revisioned, ramp_delay register is changed.
> 5mV/uS, 10mV/uS, 25mV/uS, 50mV/uS, 100mV/uS ramp delay can be selected.

This is fine but I'll wait until the preceeding patch has appeared in an
-rc before applying as there's a code dependency and the prior patch is
a bugfix which I'll send to Linus for 3.5.


Attachments:
(No filename) (386.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments