2005-09-22 19:53:38

by Lever, Charles

[permalink] [raw]
Subject: RE: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)

> Actually, Chuck's patch and Steve's aren't quite the same.
> Both patches
> fix the problem that the portmap daemon requires a request to
> set something
> to come from a reserved port. In addition to this, Steve's
> patch reduces
> the number of reserved ports that the kernel requires. This
> is the problem
> that resulted in pmap_create() being incorrectly modified in
> the first
> place.
> Steve's patch correctly puts the support in rpc_getport()
> where it belongs.

mine does too. pmap_create() is used for both GET and SET, and i added
a parm to allow pmap_create()'s caller to request a reserved port when
needed.


2005-09-22 20:09:29

by Peter Staubach

[permalink] [raw]
Subject: Re: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)

Lever, Charles wrote:

>>Actually, Chuck's patch and Steve's aren't quite the same.
>>Both patches
>>fix the problem that the portmap daemon requires a request to
>>set something
>>to come from a reserved port. In addition to this, Steve's
>>patch reduces
>>the number of reserved ports that the kernel requires. This
>>is the problem
>>that resulted in pmap_create() being incorrectly modified in
>>the first
>>place.
>>Steve's patch correctly puts the support in rpc_getport()
>>where it belongs.
>>
>>
>
>mine does too. pmap_create() is used for both GET and SET, and i added
>a parm to allow pmap_create()'s caller to request a reserved port when
>needed.
>

Hmmm. That's not the patch that Andrew Morton included in his email to
linux-kernel then. That patch just removed the line to set xprt->resvport
to 0. That one fixed problem but not the other.

Thanx...

ps