2014-10-27 15:00:09

by Krzysztof Kozlowski

Subject: [PATCH v2] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node

Add SDHCI node for supporting the micro SD card. On Trats2 board the
SDHCI does not use sd2_cd pins (gpk2-2) for card detect but gpx3-4
instead.

Power is supplied from LDO21 regulator which in off state is controlled
by external GPIO pin.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Drop FIXME comment (about findings during testing).
---
arch/arm/boot/dts/exynos4412-trats2.dts | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index a5aa52bba72c..7a68e0832cd6 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -603,6 +603,16 @@
cap-mmc-highspeed;
};

+ sdhci@12530000 {
+ bus-width = <4>;
+ cd-gpios = <&gpx3 4 0>;
+ cd-inverted;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
+ pinctrl-names = "default";
+ vmmc-supply = <&ldo21_reg>;
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
--
1.9.1

2014-10-28 10:57:44

by Kukjin Kim

Subject: RE: [PATCH v2] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node

Krzysztof Kozlowski wrote:
>
Hi,

> Add SDHCI node for supporting the micro SD card. On Trats2 board the
> SDHCI does not use sd2_cd pins (gpk2-2) for card detect but gpx3-4
> instead.
>
> Power is supplied from LDO21 regulator which in off state is controlled
> by external GPIO pin.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. Drop FIXME comment (about findings during testing).
> ---
> arch/arm/boot/dts/exynos4412-trats2.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index a5aa52bba72c..7a68e0832cd6 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -603,6 +603,16 @@
> cap-mmc-highspeed;
> };
>
> + sdhci@12530000 {
> + bus-width = <4>;
> + cd-gpios = <&gpx3 4 0>;
> + cd-inverted;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
> + pinctrl-names = "default";
> + vmmc-supply = <&ldo21_reg>;
> + status = "okay";
> + };
> +
> serial@13800000 {
> status = "okay";
> };
> --
> 1.9.1

Looks good to me, will apply.

Thanks,
Kukjin