2017-06-10 09:19:36

by Christophe JAILLET

Subject: [PATCH] cxgb4: Remove some dead code

This 'BUG_ON(!ep)' can never trigger because we have:
if (!ep)
return 0;
just a few lines above. So it can be removed safely.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/infiniband/hw/cxgb4/cm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 2f1136bf7b1f..815d7dfbdfb1 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2879,7 +2879,6 @@ static int close_con_rpl(struct c4iw_dev *dev, struct sk_buff *skb)
return 0;

pr_debug("%s ep %p tid %u\n", __func__, ep, ep->hwtid);
- BUG_ON(!ep);

/* The cm_id may be null if we failed to connect */
mutex_lock(&ep->com.mutex);
--
2.11.0

2017-06-10 12:49:06

by Steve Wise

Subject: RE: [PATCH] cxgb4: Remove some dead code

Acked-by: Steve Wise <[email protected]>

2017-08-17 22:07:01

by Doug Ledford

Subject: Re: [PATCH] cxgb4: Remove some dead code

On Sat, 2017-06-10 at 07:30 -0500, Steve Wise wrote:
> Acked-by: Steve Wise <[email protected]>

Thanks, applied.

--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD