2022-11-04 13:24:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

On 04/11/2022 08:05, Sriranjani P wrote:
> The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, one in
> FSYS0 block and other in PERIC block.
>
> Adds device tree node for Ethernet in PERIC Block and enables the same for
> FSD platform.
>
> Cc: Rob Herring <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Richard Cochran <[email protected]>
> Cc: [email protected]
> Signed-off-by: Pankaj Dubey <[email protected]>
> Signed-off-by: Jayati Sahu <[email protected]>
> Signed-off-by: Sriranjani P <[email protected]>
> ---

Same comment apply.

Best regards,
Krzysztof



2022-11-16 07:20:49

by Sriranjani P

[permalink] [raw]
Subject: RE: [PATCH 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: 04 November 2022 18:17
> To: Sriranjani P <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Rob
> Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; [email protected]; Pankaj
> Dubey <[email protected]>; Jayati Sahu
> <[email protected]>
> Subject: Re: [PATCH 4/4] arm64: dts: fsd: Add Ethernet support for PERIC
> Block of FSD SoC
>
> On 04/11/2022 08:05, Sriranjani P wrote:
> > The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP,
> > one in
> > FSYS0 block and other in PERIC block.
> >
> > Adds device tree node for Ethernet in PERIC Block and enables the same
> > for FSD platform.
> >
> > Cc: Rob Herring <[email protected]>
> > Cc: Krzysztof Kozlowski <[email protected]>
> > Cc: Richard Cochran <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Pankaj Dubey <[email protected]>
> > Signed-off-by: Jayati Sahu <[email protected]>
> > Signed-off-by: Sriranjani P <[email protected]>
> > ---
>
> Same comment apply.
[Sriranjani P] Will be fixed in the next version.
>
> Best regards,
> Krzysztof
[Sriranjani P] Thank you for the review comments.