2023-10-17 15:16:14

by Luben Tuikov

Subject: [PATCH] drm/sched: Add description of parameters in job_done

Fix a kernel test robot complaint that there's no description of the "result"
parameter to drm_sched_job_done() function.

Cc: Christian König <[email protected]>
Fixes: 539f9ee4b52a8b ("drm/scheduler: properly forward fence errors")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Luben Tuikov <[email protected]>
---
drivers/gpu/drm/scheduler/sched_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 5a3a622fc672f3..6f2cf72e79b15e 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq)
/**
* drm_sched_job_done - complete a job
* @s_job: pointer to the job which is done
+ * @result: The result of the finished scheduler fence.
*
* Finish the job's fence and wake up the worker thread.
*/

base-commit: 213f891525c222e8ed145ce1ce7ae1f47921cb9c
--
2.42.0

2023-10-17 17:12:21

by Christian König

Subject: Re: [PATCH] drm/sched: Add description of parameters in job_done

Am 17.10.23 um 17:15 schrieb Luben Tuikov:
> Fix a kernel test robot complaint that there's no description of the "result"
> parameter to drm_sched_job_done() function.
>
> Cc: Christian König <[email protected]>
> Fixes: 539f9ee4b52a8b ("drm/scheduler: properly forward fence errors")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Luben Tuikov <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/scheduler/sched_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 5a3a622fc672f3..6f2cf72e79b15e 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq)
> /**
> * drm_sched_job_done - complete a job
> * @s_job: pointer to the job which is done
> + * @result: The result of the finished scheduler fence.
> *
> * Finish the job's fence and wake up the worker thread.
> */
>
> base-commit: 213f891525c222e8ed145ce1ce7ae1f47921cb9c