2017-06-29 06:59:27

by Valentin Rothberg

[permalink] [raw]
Subject: [PATCH] nvme: Makefile: remove dead build rule

Remove dead build rule for drivers/nvme/host/scsi.c which has been
removed by commit ("nvme: Remove SCSI translations").

Signed-off-by: Valentin Rothberg <[email protected]>
---
drivers/nvme/host/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/Makefile b/drivers/nvme/host/Makefile
index f1a7d945fbb6..cc0aacb4c8b4 100644
--- a/drivers/nvme/host/Makefile
+++ b/drivers/nvme/host/Makefile
@@ -5,7 +5,6 @@ obj-$(CONFIG_NVME_RDMA) += nvme-rdma.o
obj-$(CONFIG_NVME_FC) += nvme-fc.o

nvme-core-y := core.o
-nvme-core-$(CONFIG_BLK_DEV_NVME_SCSI) += scsi.o
nvme-core-$(CONFIG_NVM) += lightnvm.o

nvme-y += pci.o
--
2.12.3


2017-06-29 08:33:25

by Johannes Thumshirn

[permalink] [raw]
Subject: Re: [PATCH] nvme: Makefile: remove dead build rule

On Thu, Jun 29, 2017 at 08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
>
> Signed-off-by: Valentin Rothberg <[email protected]>
> ---

Looks good,
Reviewed-by: Johannes Thumshirn <[email protected]>
--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

2017-06-29 14:37:23

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] nvme: Makefile: remove dead build rule

Looks fine,

Reviewed-by: Christoph Hellwig <[email protected]>

2017-06-29 14:51:08

by Keith Busch

[permalink] [raw]
Subject: Re: [PATCH] nvme: Makefile: remove dead build rule

On Thu, Jun 29, 2017 at 08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
>
> Signed-off-by: Valentin Rothberg <[email protected]>

Oops, thanks for the fix.

Reviewed-by: Keith Busch <[email protected]>

2017-06-29 15:44:39

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] nvme: Makefile: remove dead build rule

On 06/29/2017 12:59 AM, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").

Added, thanks.

--
Jens Axboe