2018-07-23 23:30:32

by Suman Anna

Subject: [PATCH] remoteproc/davinci: Mark error recovery as disabled

The Davinci remoteproc driver does not support error recovery at
present, so mark the corresponding remoteproc flag appropriately
so that the debugfs flag shows the value as 'disabled' by default.

Signed-off-by: Suman Anna <[email protected]>
---
drivers/remoteproc/da8xx_remoteproc.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index b668e32996e2..53160d5ed543 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
goto free_mem;
}

+ /* error recovery is not supported at present */
+ rproc->recovery_disabled = true;
+
drproc = rproc->priv;
drproc->rproc = rproc;
drproc->dsp_clk = dsp_clk;
--
2.18.0

2018-08-13 15:40:58

by Suman Anna

Subject: Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

Hi Bjorn,

On 07/23/2018 06:27 PM, Suman Anna wrote:
> The Davinci remoteproc driver does not support error recovery at
> present, so mark the corresponding remoteproc flag appropriately
> so that the debugfs flag shows the value as 'disabled' by default.
>
> Signed-off-by: Suman Anna <[email protected]>

Can you pick up this minor patch for 4.19 please, I do not see this in
your rproc-next branch?

Thanks,
Suman

> ---
> drivers/remoteproc/da8xx_remoteproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index b668e32996e2..53160d5ed543 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> goto free_mem;
> }
>
> + /* error recovery is not supported at present */
> + rproc->recovery_disabled = true;
> +
> drproc = rproc->priv;
> drproc->rproc = rproc;
> drproc->dsp_clk = dsp_clk;
>

2018-08-13 18:53:19

by Bjorn Andersson

Subject: Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote:

> Hi Bjorn,
>
> On 07/23/2018 06:27 PM, Suman Anna wrote:
> > The Davinci remoteproc driver does not support error recovery at
> > present, so mark the corresponding remoteproc flag appropriately
> > so that the debugfs flag shows the value as 'disabled' by default.
> >
> > Signed-off-by: Suman Anna <[email protected]>
>
> Can you pick up this minor patch for 4.19 please, I do not see this in
> your rproc-next branch?
>

Of course, the patch is applied now, will send my pull request in a few
days.

Regards,
Bjorn

> Thanks,
> Suman
>
> > ---
> > drivers/remoteproc/da8xx_remoteproc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> > index b668e32996e2..53160d5ed543 100644
> > --- a/drivers/remoteproc/da8xx_remoteproc.c
> > +++ b/drivers/remoteproc/da8xx_remoteproc.c
> > @@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> > goto free_mem;
> > }
> >
> > + /* error recovery is not supported at present */
> > + rproc->recovery_disabled = true;
> > +
> > drproc = rproc->priv;
> > drproc->rproc = rproc;
> > drproc->dsp_clk = dsp_clk;
> >
>

2018-08-14 05:22:42

by Sekhar Nori

Subject: Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

Hi Bjorn,

On Tuesday 14 August 2018 12:22 AM, Bjorn Andersson wrote:
> On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote:
>
>> Hi Bjorn,
>>
>> On 07/23/2018 06:27 PM, Suman Anna wrote:
>>> The Davinci remoteproc driver does not support error recovery at
>>> present, so mark the corresponding remoteproc flag appropriately
>>> so that the debugfs flag shows the value as 'disabled' by default.
>>>
>>> Signed-off-by: Suman Anna <[email protected]>
>>
>> Can you pick up this minor patch for 4.19 please, I do not see this in
>> your rproc-next branch?
>>
>
> Of course, the patch is applied now, will send my pull request in a few
> days.

Can you also please pick patch 1/4 here:

https://patchwork.kernel.org/patch/10479365/

Thanks,
Sekhar