2014-12-23 18:08:17

by Nicholas Mc Guire

Subject: [PATCH] scsi: unnecessary double init_completion removed

The double call to init_completion(&ha->disable_acb_comp); looks like
an editing mistake only - dropped.

patch is against 3.18.0 linux-next

scripts/get_maintainer.pl -f drivers/scsi/qla4xxx/ql4_os.c returned
Vikas Chaudhary <[email protected]> (supporter:QLOGIC QLA4XXX iS...)
but that no longer seems to be a valid e-mail address.

Signed-off-by: Nicholas Mc Guire <[email protected]>
---
drivers/scsi/qla4xxx/ql4_os.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 6d25879..0c1da76 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -8672,7 +8672,6 @@ static int qla4xxx_probe_adapter(struct pci_dev *pdev,
init_completion(&ha->disable_acb_comp);
init_completion(&ha->idc_comp);
init_completion(&ha->link_up_comp);
- init_completion(&ha->disable_acb_comp);

spin_lock_init(&ha->hardware_lock);
spin_lock_init(&ha->work_lock);
--
1.7.10.4

2014-12-31 12:41:51

by Nilesh Javali

Subject: RE: [PATCH] scsi: unnecessary double init_completion removed

Acked-by: Nilesh Javali <[email protected]>

I will send the maintainer list update patch.

Thanks,
Nilesh

-----Original Message-----
From: Nicholas Mc Guire [mailto:[email protected]]
Sent: Tuesday, December 23, 2014 11:30 PM
To: James E.J. Bottomley
Cc: Dept-Eng iSCSI Driver; linux-scsi; linux-kernel; Nicholas Mc Guire
Subject: [PATCH] scsi: unnecessary double init_completion removed

The double call to init_completion(&ha->disable_acb_comp); looks like an editing mistake only - dropped.

patch is against 3.18.0 linux-next

scripts/get_maintainer.pl -f drivers/scsi/qla4xxx/ql4_os.c returned Vikas Chaudhary <[email protected]> (supporter:QLOGIC QLA4XXX iS...) but that no longer seems to be a valid e-mail address.

Signed-off-by: Nicholas Mc Guire <[email protected]>
---
drivers/scsi/qla4xxx/ql4_os.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 6d25879..0c1da76 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -8672,7 +8672,6 @@ static int qla4xxx_probe_adapter(struct pci_dev *pdev,
init_completion(&ha->disable_acb_comp);
init_completion(&ha->idc_comp);
init_completion(&ha->link_up_comp);
- init_completion(&ha->disable_acb_comp);

spin_lock_init(&ha->hardware_lock);
spin_lock_init(&ha->work_lock);
--
1.7.10.4