2023-01-16 07:56:07

by Walker Chen

Subject: [PATCH v3 1/3] dt-bindings: power: Add starfive,jh7110-pmu

Add bindings for the Power Management Unit on the StarFive JH7110 SoC.

Signed-off-by: Walker Chen <[email protected]>
---
.../bindings/power/starfive,jh7110-pmu.yaml | 45 +++++++++++++++++++
.../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++
2 files changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml
create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h

diff --git a/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml
new file mode 100644
index 000000000000..98eb8b4110e7
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/starfive,jh7110-pmu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: StarFive JH7110 Power Management Unit
+
+maintainers:
+ - Walker Chen <[email protected]>
+
+description: |
+ StarFive JH7110 SoC includes support for multiple power domains which can be
+ powered on/off by software based on different application scenes to save power.
+
+properties:
+ compatible:
+ enum:
+ - starfive,jh7110-pmu
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#power-domain-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - "#power-domain-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ pwrc: power-controller@17030000 {
+ compatible = "starfive,jh7110-pmu";
+ reg = <0x17030000 0x10000>;
+ interrupts = <111>;
+ #power-domain-cells = <1>;
+ };
diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h
new file mode 100644
index 000000000000..132bfe401fc8
--- /dev/null
+++ b/include/dt-bindings/power/starfive,jh7110-pmu.h
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (C) 2022 StarFive Technology Co., Ltd.
+ * Author: Walker Chen <[email protected]>
+ */
+#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__
+#define __DT_BINDINGS_POWER_JH7110_POWER_H__
+
+#define JH7110_PD_SYSTOP 0
+#define JH7110_PD_CPU 1
+#define JH7110_PD_GPUA 2
+#define JH7110_PD_VDEC 3
+#define JH7110_PD_VOUT 4
+#define JH7110_PD_ISP 5
+#define JH7110_PD_VENC 6
+
+#endif
--
2.17.1

2023-01-17 11:56:09

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 1/3] dt-bindings: power: Add starfive,jh7110-pmu

On 16/01/2023 08:42, Walker Chen wrote:
> Add bindings for the Power Management Unit on the StarFive JH7110 SoC.
>
> Signed-off-by: Walker Chen <[email protected]>
> ---
> .../bindings/power/starfive,jh7110-pmu.yaml | 45 +++++++++++++++++++
> .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++
> 2 files changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml
> create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-01-18 08:46:16

by Walker Chen

Subject: Re: [PATCH v3 1/3] dt-bindings: power: Add starfive,jh7110-pmu

On 2023/1/17 18:55, Krzysztof Kozlowski wrote:
> On 16/01/2023 08:42, Walker Chen wrote:
>> Add bindings for the Power Management Unit on the StarFive JH7110 SoC.
>>
>> Signed-off-by: Walker Chen <[email protected]>
>> ---
>> .../bindings/power/starfive,jh7110-pmu.yaml | 45 +++++++++++++++++++
>> .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++
>> 2 files changed, 62 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml
>> create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h
>>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Best regards,
> Krzysztof
>

Thanks a lot for your review!

Best regards,
Walker