2023-07-10 07:25:32

by Su Hui

Subject: [PATCH net-next v2 04/10] net: hns3: remove unnecessary (void*) conversions

From: wuych <[email protected]>

Pointer variables of void * type do not require type cast.

Signed-off-by: wuych <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
index 407d30ee55d2..36858a72d771 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
@@ -569,8 +569,8 @@ static void hns3_get_strings(struct net_device *netdev, u32 stringset, u8 *data)

static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data)
{
- struct hns3_nic_priv *nic_priv = (struct hns3_nic_priv *)handle->priv;
struct hnae3_knic_private_info *kinfo = &handle->kinfo;
+ struct hns3_nic_priv *nic_priv = handle->priv;
struct hns3_enet_ring *ring;
u8 *stat;
int i, j;
--
2.30.2

2023-07-11 02:38:49

by Hao Lan

Subject: Re: [PATCH net-next v2 04/10] net: hns3: remove unnecessary (void*) conversions

On 2023/7/10 14:40, Su Hui wrote:
> From: wuych <[email protected]>
>
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <[email protected]>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 407d30ee55d2..36858a72d771 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -569,8 +569,8 @@ static void hns3_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
>
> static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data)
> {
> - struct hns3_nic_priv *nic_priv = (struct hns3_nic_priv *)handle->priv;
> struct hnae3_knic_private_info *kinfo = &handle->kinfo;
> + struct hns3_nic_priv *nic_priv = handle->priv;
> struct hns3_enet_ring *ring;
> u8 *stat;
> int i, j;
>
Reviewed-by: Hao Lan <[email protected]>