2016-04-05 02:38:58

by Geliang Tang

Subject: [PATCH] cpufreq: mt8173: use list_for_each_entry*()

Use list_for_each_entry*() instead of list_for_each*() to simplify
the code.

Signed-off-by: Geliang Tang <[email protected]>
---
drivers/cpufreq/mt8173-cpufreq.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
index 2058e6d..6f602c7 100644
--- a/drivers/cpufreq/mt8173-cpufreq.c
+++ b/drivers/cpufreq/mt8173-cpufreq.c
@@ -59,11 +59,8 @@ static LIST_HEAD(dvfs_info_list);
static struct mtk_cpu_dvfs_info *mtk_cpu_dvfs_info_lookup(int cpu)
{
struct mtk_cpu_dvfs_info *info;
- struct list_head *list;
-
- list_for_each(list, &dvfs_info_list) {
- info = list_entry(list, struct mtk_cpu_dvfs_info, list_head);

+ list_for_each_entry(info, &dvfs_info_list, list_head) {
if (cpumask_test_cpu(cpu, &info->cpus))
return info;
}
@@ -524,8 +521,7 @@ static struct cpufreq_driver mt8173_cpufreq_driver = {

static int mt8173_cpufreq_probe(struct platform_device *pdev)
{
- struct mtk_cpu_dvfs_info *info;
- struct list_head *list, *tmp;
+ struct mtk_cpu_dvfs_info *info, *tmp;
int cpu, ret;

for_each_possible_cpu(cpu) {
@@ -559,11 +555,9 @@ static int mt8173_cpufreq_probe(struct platform_device *pdev)
return 0;

release_dvfs_info_list:
- list_for_each_safe(list, tmp, &dvfs_info_list) {
- info = list_entry(list, struct mtk_cpu_dvfs_info, list_head);
-
+ list_for_each_entry_safe(info, tmp, &dvfs_info_list, list_head) {
mtk_cpu_dvfs_info_release(info);
- list_del(list);
+ list_del(&info->list_head);
}

return ret;
--
2.5.5

2016-04-05 03:06:04

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: mt8173: use list_for_each_entry*()

On 05-04-16, 10:38, Geliang Tang wrote:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code.
>
> Signed-off-by: Geliang Tang <[email protected]>
> ---
> drivers/cpufreq/mt8173-cpufreq.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2016-04-22 00:38:48

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: mt8173: use list_for_each_entry*()

On Tuesday, April 05, 2016 08:35:57 AM Viresh Kumar wrote:
> On 05-04-16, 10:38, Geliang Tang wrote:
> > Use list_for_each_entry*() instead of list_for_each*() to simplify
> > the code.
> >
> > Signed-off-by: Geliang Tang <[email protected]>
> > ---
> > drivers/cpufreq/mt8173-cpufreq.c | 14 ++++----------
> > 1 file changed, 4 insertions(+), 10 deletions(-)
>
> Acked-by: Viresh Kumar <[email protected]>

Applied, thanks!