On 19/07/2023 5:10, 王明-软件底层技术部 wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in bond_create_debugfs() was forgotten.
>
> Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding driver")
> Signed-off-by: Wang Ming <[email protected]>
> ---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
> index 594094526648..d4a82f276e87 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
> {
> bonding_debug_root = debugfs_create_dir("bonding", NULL);
>
> - if (!bonding_debug_root)
> + if (IS_ERR(bonding_debug_root))
> pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
>
Reviewed-by: Tariq Toukan <[email protected]>
Thanks.