2017-06-13 20:43:13

by Gustavo A. R. Silva

Subject: [PATCH] rtlwifi: rtl8821ae: remove unused variable

Remove unused variable rtlhal.

Addresses-Coverity-ID: 1248810
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
index 2bc6bac..d158e34 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
@@ -1360,7 +1360,6 @@ static bool _rtl8821ae_reset_pcie_interface_dma(struct ieee80211_hw *hw,
static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
- struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv);
u8 fw_reason = 0;
struct timeval ts;
@@ -1372,8 +1371,6 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)

ppsc->wakeup_reason = 0;

- rtlhal->last_suspend_sec = ts.tv_sec;
-
switch (fw_reason) {
case FW_WOW_V2_PTK_UPDATE_EVENT:
ppsc->wakeup_reason = WOL_REASON_PTK_UPDATE;
--
2.5.0

2017-06-16 20:38:41

by Larry Finger

Subject: Re: [PATCH] rtlwifi: rtl8821ae: remove unused variable

On 06/13/2017 03:42 PM, Gustavo A. R. Silva wrote:
> Remove unused variable rtlhal.
>
> Addresses-Coverity-ID: 1248810
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---

NACK!! That variable is used in file core.c in driver rtlwifi, which is loaded
and used by rtl8821ae.

Please do more than blindly follow Coverity outputs, or improve that tool!

Larry

> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index 2bc6bac..d158e34 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -1360,7 +1360,6 @@ static bool _rtl8821ae_reset_pcie_interface_dma(struct ieee80211_hw *hw,
> static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> - struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
> struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv);
> u8 fw_reason = 0;
> struct timeval ts;
> @@ -1372,8 +1371,6 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
>
> ppsc->wakeup_reason = 0;
>
> - rtlhal->last_suspend_sec = ts.tv_sec;
> -
> switch (fw_reason) {
> case FW_WOW_V2_PTK_UPDATE_EVENT:
> ppsc->wakeup_reason = WOL_REASON_PTK_UPDATE;
>